Commit 07cab687 authored by dewittj's avatar dewittj Committed by Commit bot

[Offline Pages] Adds storage for kInvalidOfflineId.

Since kInvalidOfflineId is a static data member, it needs explicitly
defined storage as soon as it becomes 'odr-used'.  Replace a temporary
variable in RecentTabHelper with storage in offline_page_model.cc both
for clarity and to allow further references to kInvalidOfflineId to be
taken.

BUG=

Review-Url: https://codereview.chromium.org/2548033002
Cr-Commit-Position: refs/heads/master@{#436116}
parent 62cbfb83
...@@ -153,9 +153,8 @@ void RecentTabHelper::DidFinishNavigation( ...@@ -153,9 +153,8 @@ void RecentTabHelper::DidFinishNavigation(
} }
if (offline_pages::IsOffliningRecentPagesEnabled()) { if (offline_pages::IsOffliningRecentPagesEnabled()) {
int64_t proposed_id = OfflinePageModel::kInvalidOfflineId;
download_info_ = base::MakeUnique<DownloadPageInfo>( download_info_ = base::MakeUnique<DownloadPageInfo>(
GetRecentPagesClientId(), proposed_id); GetRecentPagesClientId(), OfflinePageModel::kInvalidOfflineId);
} else { } else {
download_info_.reset(); download_info_.reset();
} }
......
...@@ -8,6 +8,8 @@ ...@@ -8,6 +8,8 @@
namespace offline_pages { namespace offline_pages {
const int64_t OfflinePageModel::kInvalidOfflineId;
OfflinePageModel::SavePageParams::SavePageParams() OfflinePageModel::SavePageParams::SavePageParams()
: proposed_offline_id(OfflinePageModel::kInvalidOfflineId) { : proposed_offline_id(OfflinePageModel::kInvalidOfflineId) {
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment