Commit 07e01081 authored by Clemens Arbesser's avatar Clemens Arbesser Committed by Commit Bot

[Autofill Assistant] Changed comment for KeyPress.keyboard_input proto for clarification.

Bug: 806868
Change-Id: Iba3d0a38f1d215880b3479a5c1baa2d3d4d97b24
Reviewed-on: https://chromium-review.googlesource.com/c/1355164Reviewed-by: default avatarStephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#612257}
parent b4176f47
...@@ -75,7 +75,7 @@ void SetFormFieldValueAction::OnSetFieldValue(ActionDelegate* delegate, ...@@ -75,7 +75,7 @@ void SetFormFieldValueAction::OnSetFieldValue(ActionDelegate* delegate,
// DEPRECATED: the field `keycode' used to contain a single character to // DEPRECATED: the field `keycode' used to contain a single character to
// input as text. Since there is no easy way to convert keycodes to text, // input as text. Since there is no easy way to convert keycodes to text,
// this field is now deprecated and only works for US-ASCII characters. // this field is now deprecated and only works for US-ASCII characters.
// You should use the `key' field instead. // You should use the `keyboard_input' field instead.
if (key_field.keycode() < 128) { // US-ASCII if (key_field.keycode() < 128) { // US-ASCII
delegate->SendKeyboardInput( delegate->SendKeyboardInput(
selector, std::string(1, char(key_field.keycode())), selector, std::string(1, char(key_field.keycode())),
......
...@@ -579,10 +579,9 @@ message SetFormFieldValueProto { ...@@ -579,10 +579,9 @@ message SetFormFieldValueProto {
string text = 1; string text = 1;
// DEPRECATED: A single US-ASCII character (e.g., 13 for carriage return). // DEPRECATED: A single US-ASCII character (e.g., 13 for carriage return).
int32 keycode = 2; int32 keycode = 2;
// One or multiple UTF-8 characters to input in the form element. In // Text as generated by processing a virtual key code with a keyboard
// contrast to |text|, |keyboard_input| is evaluated as if the user had // layout. This can also be used for keyboard control sequences such
// tapped the keyboard. This can also be used for control sequences such // as "\r" or "\t".
// as "\r".
string keyboard_input = 3; string keyboard_input = 3;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment