Commit 0820b8e9 authored by btolsch's avatar btolsch Committed by Commit Bot

Remove fullscreen toast in PresentationReceiverWindowView on Chrome OS

The text in the fullscreen exit toast is confusing on Chrome OS since it
is not commonly known how to access the F11 key.  It is not usually used
in BrowserView since immersive mode is used instead.  Additionally,
Chromebooks have a hardware fullscreen toggle button which should be
easily accessible for exiting fullscreen.

Bug: 825803
Change-Id: I855c9920e37e4176140c874e4a7c357cc6ab3e22
Reviewed-on: https://chromium-review.googlesource.com/988940Reviewed-by: default avatarDerek Cheng <imcheng@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547632}
parent aa48ce8d
...@@ -318,7 +318,15 @@ void PresentationReceiverWindowView::UpdateExclusiveAccessExitBubbleContent( ...@@ -318,7 +318,15 @@ void PresentationReceiverWindowView::UpdateExclusiveAccessExitBubbleContent(
const GURL& url, const GURL& url,
ExclusiveAccessBubbleType bubble_type, ExclusiveAccessBubbleType bubble_type,
ExclusiveAccessBubbleHideCallback bubble_first_hide_callback) { ExclusiveAccessBubbleHideCallback bubble_first_hide_callback) {
#if defined(CHROMEOS)
// On Chrome OS, we will not show the toast for the normal browser fullscreen
// mode. The 'F11' text is confusing since how to access F11 on a Chromebook
// is not common knowledge and there is also a dedicated fullscreen toggle
// button available.
if (bubble_type == EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE || url.is_empty()) {
#else
if (bubble_type == EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE) { if (bubble_type == EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE) {
#endif
// |exclusive_access_bubble_.reset()| will trigger callback for current // |exclusive_access_bubble_.reset()| will trigger callback for current
// bubble with |ExclusiveAccessBubbleHideReason::kInterrupted| if available. // bubble with |ExclusiveAccessBubbleHideReason::kInterrupted| if available.
exclusive_access_bubble_.reset(); exclusive_access_bubble_.reset();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment