Fix "multiple rules generate ..." warning when using multiple toolchains
The target //third_party/test_fonts copy the files to the same location for all toolchains, so when using multiple toolchains (which is common when targeting iOS) and multiple toolchains depends on that target (it can happen when building cronet), ninja presents a warning because some files are copied to the same location. Change the target to copy the files to $root_out_dir instead of $root_build_dir which correspond to the same directory for the default toolchain but to a toolchain specific directory for the secondary toolchains (this is consistent with the other target that copy fonts defined in //skia). Also fix iOS build to also use a bundle for the fonts (since iOS apps cannot access file outside of the application bundle). Bug: none Change-Id: Ic5e3290a495f67744f9d676800e16612ffefcbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992428Reviewed-by:Dominik Röttsches <drott@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#730182}
Showing
Please register or sign in to comment