sync: Move NonBlockingTypeProcessor to sync/engine

Moves NonBlockingTypeProcessor from sync/internal_api to sync/engine.

It's become increasingly clear to me that the NonBlockingTypeProcessor
will be too big to expose outside of sync.  When it comes time to export
its functionality, we'll need to define a wrapper class with a simpler
interface.  This means that there's no benefit to keeping it in
internal_api.

There is a benefit to moving this to sync/engine.  In this location, it
should be able to collaborate more closely with its sibling, the
NonBlockingTypeProcessorCore.

We intend to start adding lots of code to this class soon.  It's a good
idea to get this move out of the way first, so we can have a better git
history in the end.

BUG=351005

Review URL: https://codereview.chromium.org/280693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270025 0039d316-1c4b-4281-b951-d872f2087c98

components/sync_driver/non_blocking_data_type_controller.cc

@@ -7,7 +7,7 @@
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
-#include "sync/internal_api/public/non_blocking_type_processor.h"
+#include "sync/engine/non_blocking_type_processor.h"
 
 namespace browser_sync {
 

components/sync_driver/non_blocking_data_type_controller_unittest.cc

@@ -11,8 +11,8 @@
 #include "base/sequenced_task_runner.h"
 #include "base/test/test_simple_task_runner.h"
 #include "components/sync_driver/non_blocking_data_type_controller.h"
+#include "sync/engine/non_blocking_type_processor.h"
 #include "sync/internal_api/public/base/model_type.h"
-#include "sync/internal_api/public/non_blocking_type_processor.h"
 #include "sync/internal_api/public/sync_core_proxy.h"
 #include "testing/gtest/include/gtest/gtest.h"
 

components/sync_driver/non_blocking_data_type_manager.cc

@@ -6,7 +6,7 @@
 
 #include "base/sequenced_task_runner.h"
 #include "components/sync_driver/non_blocking_data_type_controller.h"
-#include "sync/internal_api/public/non_blocking_type_processor.h"
+#include "sync/engine/non_blocking_type_processor.h"
 
 namespace browser_sync {
 

sync/engine/DEPS

 include_rules = [
   "+sync/base",
-  "+sync/internal_api/public/base",
-  "+sync/internal_api/public/engine",
-  "+sync/internal_api/public/events",
-  "+sync/internal_api/public/sessions",
-  "+sync/internal_api/public/test",
-  "+sync/internal_api/public/util",
+  "+sync/internal_api/public",
   "+sync/notifier",
   "+sync/protocol",
   "+sync/sessions",

sync/internal_api/non_blocking_type_processor.cc → sync/engine/non_blocking_type_processor.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "sync/internal_api/public/non_blocking_type_processor.h"
+#include "sync/engine/non_blocking_type_processor.h"
 
 #include "base/message_loop/message_loop_proxy.h"
 #include "sync/engine/non_blocking_type_processor_core.h"

sync/internal_api/sync_core_proxy_impl_unittest.cc

@@ -6,8 +6,8 @@
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/run_loop.h"
 #include "base/sequenced_task_runner.h"
+#include "sync/engine/non_blocking_type_processor.h"
 #include "sync/internal_api/public/base/model_type.h"
-#include "sync/internal_api/public/non_blocking_type_processor.h"
 #include "sync/internal_api/sync_core.h"
 #include "sync/internal_api/sync_core_proxy_impl.h"
 #include "sync/sessions/model_type_registry.h"

sync/sessions/model_type_registry.cc

@@ -9,8 +9,8 @@
 #include "base/observer_list.h"
 #include "sync/engine/directory_commit_contributor.h"
 #include "sync/engine/directory_update_handler.h"
+#include "sync/engine/non_blocking_type_processor.h"
 #include "sync/engine/non_blocking_type_processor_core.h"
-#include "sync/internal_api/public/non_blocking_type_processor.h"
 #include "sync/sessions/directory_type_debug_info_emitter.h"
 
 namespace syncer {

sync/sessions/model_type_registry_unittest.cc

@@ -6,8 +6,8 @@
 
 #include "base/deferred_sequenced_task_runner.h"
 #include "base/message_loop/message_loop.h"
+#include "sync/engine/non_blocking_type_processor.h"
 #include "sync/internal_api/public/base/model_type.h"
-#include "sync/internal_api/public/non_blocking_type_processor.h"
 #include "sync/sessions/model_type_registry.h"
 #include "sync/test/engine/fake_model_worker.h"
 #include "sync/test/engine/test_directory_setter_upper.h"

sync/sync_core.gypi

@@ -64,6 +64,8 @@
     'engine/net/server_connection_manager.h',
     'engine/net/url_translator.cc',
     'engine/net/url_translator.h',
+    'engine/non_blocking_type_processor.cc',
+    'engine/non_blocking_type_processor.h',
     'engine/non_blocking_type_processor_core.cc',
     'engine/non_blocking_type_processor_core.h',
     'engine/nudge_source.cc',

sync/sync_internal_api.gypi

@@ -42,7 +42,6 @@
     'internal_api/js_sync_encryption_handler_observer.h',
     'internal_api/js_sync_manager_observer.cc',
     'internal_api/js_sync_manager_observer.h',
-    'internal_api/non_blocking_type_processor.cc',
     'internal_api/protocol_event_buffer.cc',
     'internal_api/protocol_event_buffer.h',
     'internal_api/public/attachments/fake_attachment_store.h',
@@ -98,7 +97,6 @@
     'internal_api/public/internal_components_factory.h',
     'internal_api/public/internal_components_factory_impl.h',
     'internal_api/public/network_resources.h',
-    'internal_api/public/non_blocking_type_processor.h',
     'internal_api/public/read_node.h',
     'internal_api/public/read_transaction.h',
     'internal_api/public/sessions/commit_counters.cc',