Properly initialize variables in RequestContentScript::ScriptData

POD members of RequestContentScript::ScriptData weren't being initialized,
which a) is really bad because who knows what they might have been, and b)
is bad because it makes Dr. Memory unhappy.  Fix it (and pull ScriptData into
the .cc while we're at it).

BUG=409865

Review URL: https://codereview.chromium.org/531823002

Cr-Commit-Position: refs/heads/master@{#292960}

chrome/browser/extensions/api/declarative_content/content_action.cc

@@ -157,7 +157,19 @@ base::LazyInstance<ContentActionFactory>::Leaky
 // RequestContentScript
 //
 
-RequestContentScript::ScriptData::ScriptData() {}
+struct RequestContentScript::ScriptData {
+  ScriptData();
+  ~ScriptData();
+
+  std::vector<std::string> css_file_names;
+  std::vector<std::string> js_file_names;
+  bool all_frames;
+  bool match_about_blank;
+};
+
+RequestContentScript::ScriptData::ScriptData()
+    : all_frames(false),
+      match_about_blank(false) {}
 RequestContentScript::ScriptData::~ScriptData() {}
 
 // static

chrome/browser/extensions/api/declarative_content/content_action.h

@@ -92,15 +92,7 @@ class ContentAction : public base::RefCounted<ContentAction> {
 // Action that injects a content script.
 class RequestContentScript : public ContentAction {
  public:
-  struct ScriptData {
-    ScriptData();
-    ~ScriptData();
-
-    std::vector<std::string> css_file_names;
-    std::vector<std::string> js_file_names;
-    bool all_frames;
-    bool match_about_blank;
-  };
+  struct ScriptData;
 
   RequestContentScript(content::BrowserContext* browser_context,
                        const Extension* extension,

tools/valgrind/drmemory/suppressions_full.txt

@@ -2197,11 +2197,3 @@ content.dll!content::WebContentsImpl::CreateRenderViewForRenderManager
 content.dll!content::NavigationControllerImpl::LoadEntry
 ...
 *!extensions::ExtensionHost::LoadInitialURL
-
-UNINITIALIZED READ
-name=bug_409865
-*!Pickle::WriteBool
-*!extensions::UserScript::Pickle
-*!extensions::`anonymous namespace'::Serialize
-*!extensions::`anonymous namespace'::LoadScriptsOnFileThread
-*!base::internal::RunnableAdapter<>::Run