Commit 087e7183 authored by miguelg@chromium.org's avatar miguelg@chromium.org

[PUSH] Fix lifetime of the hasPermission callback in layout Tests.

The promise needs to be created before calling the client for
layout tests to work, it does not seem to be an issue in real code.

BUG=401424

Review URL: https://codereview.chromium.org/709733003

git-svn-id: svn://svn.chromium.org/blink/trunk@185049 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent a42dfb80
...@@ -83,8 +83,9 @@ ScriptPromise PushManager::hasPermission(ScriptState* scriptState) ...@@ -83,8 +83,9 @@ ScriptPromise PushManager::hasPermission(ScriptState* scriptState)
RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState); RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
client->getPermissionStatus(new PushPermissionStatusCallback(resolver), serviceWorkerProvider); client->getPermissionStatus(new PushPermissionStatusCallback(resolver), serviceWorkerProvider);
return resolver->promise(); return promise;
} }
void PushManager::doRegister(WebPushClient* client, PassRefPtr<ScriptPromiseResolver> resolver, WebServiceWorkerProvider* serviceWorkerProvider) void PushManager::doRegister(WebPushClient* client, PassRefPtr<ScriptPromiseResolver> resolver, WebServiceWorkerProvider* serviceWorkerProvider)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment