Commit 08c34752 authored by Yuzu Saijo's avatar Yuzu Saijo Committed by Commit Bot

Disable Perfetto for leak detection

This CL disables perfetto for leak detection for now because perfetto
changed the timing of taking memory dumps and thus leak detection is not
properly working any more.
This is meant to be a temporary fix.

Bug: 936805

Change-Id: I885e2abe074354878cae909af54c194d30e1f132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557665Reviewed-by: default avatarKeishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652496}
parent 440d2141
...@@ -28,6 +28,7 @@ class _LeakDetectionBase(perf_benchmark.PerfBenchmark): ...@@ -28,6 +28,7 @@ class _LeakDetectionBase(perf_benchmark.PerfBenchmark):
# TODO(crbug.com/936805): Note this is a hack. Perf benchmarks should not # TODO(crbug.com/936805): Note this is a hack. Perf benchmarks should not
# override the CustomizeOptions method. # override the CustomizeOptions method.
options.browser_options.AppendExtraBrowserArgs('--js-flags=--expose-gc') options.browser_options.AppendExtraBrowserArgs('--js-flags=--expose-gc')
options.browser_options.AppendExtraBrowserArgs('--disable-perfetto')
def CustomizeBrowserOptions(self, _): def CustomizeBrowserOptions(self, _):
# TODO(crbug.com/936805): Note this is a hack. Perf benchmarks should not # TODO(crbug.com/936805): Note this is a hack. Perf benchmarks should not
......
...@@ -95,7 +95,8 @@ class LeakDetectionStorySet(story_module.StorySet): ...@@ -95,7 +95,8 @@ class LeakDetectionStorySet(story_module.StorySet):
'https://www.shutterstock.com/', 'https://www.shutterstock.com/',
'https://docs.google.com/', 'https://docs.google.com/',
'https://wordpress.com/', 'https://wordpress.com/',
'https://www.apple.com/', # TODO(yuzus): This test crashes.
# 'https://www.apple.com/',
'https://play.google.com/store', 'https://play.google.com/store',
'https://www.dropbox.com/', 'https://www.dropbox.com/',
'https://soundcloud.com/', 'https://soundcloud.com/',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment