Commit 08c63e8a authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

[BrowserThread] Remove DCHECK which invokes ExtractBrowserThreadId()

This is preventing the migration of callers that use BrowserTaskTraits
specific traits when invoking GetUIThreadTaskRunner() @
https://chromium-review.googlesource.com/c/chromium/src/+/2211138/8

R=altimin@chromium.org

Bug: 1026641
Change-Id: I098daf92d861447049315332f42d2d53fae15d1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212992Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771845}
parent 6e6833d9
......@@ -96,10 +96,6 @@ BaseBrowserTaskExecutor::CreateCOMSTATaskRunner(
scoped_refptr<base::SingleThreadTaskRunner>
BaseBrowserTaskExecutor::GetTaskRunner(BrowserThread::ID identifier,
const base::TaskTraits& traits) const {
DCHECK(traits.extension_id() ==
base::TaskTraitsExtensionStorage::kInvalidExtensionId ||
ExtractBrowserThreadId(traits) == identifier);
const QueueType queue_type = GetQueueType(traits);
switch (identifier) {
......
......@@ -120,6 +120,16 @@ TEST_F(BrowserTaskExecutorTest, RunAllPendingTasksForTestingOnIOIsReentrant) {
BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting(BrowserThread::IO);
}
TEST_F(BrowserTaskExecutorTest, GetTaskRunnerWithBrowserTaskTraits) {
StrictMockTask task_1;
GetUIThreadTaskRunner({BrowserTaskType::kPreconnect})
->PostTask(FROM_HERE, task_1.Get());
EXPECT_CALL(task_1, Run);
BrowserTaskExecutor::RunAllPendingTasksOnThreadForTesting(BrowserThread::UI);
}
// Helper to perform the same tets for all BrowserThread::ID values.
class BrowserTaskTraitsMappingTest : public BrowserTaskExecutorTest {
protected:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment