Commit 08e3c1f6 authored by Will Harris's avatar Will Harris Committed by Commit Bot

Fix Resources path diagnostics test to not fail for read-only files.

This removes the system level precondition and will now only run the
test if the file is actually meant to be read-only.

BUG=843211

Change-Id: I55abddd4f250732f815875dd626a80bda999f205
Reviewed-on: https://chromium-review.googlesource.com/1060172
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560843}
parent 450d4a7d
...@@ -218,8 +218,6 @@ const TestPathInfo kPathsToTest[] = { ...@@ -218,8 +218,6 @@ const TestPathInfo kPathsToTest[] = {
}; };
// Check that the user's data directory exists and the paths are writable. // Check that the user's data directory exists and the paths are writable.
// If it is a system-wide install some paths are not expected to be writable.
// This test depends on |InstallTypeTest| having run successfully.
class PathTest : public DiagnosticsTest { class PathTest : public DiagnosticsTest {
public: public:
explicit PathTest(const TestPathInfo& path_info) explicit PathTest(const TestPathInfo& path_info)
...@@ -266,7 +264,7 @@ class PathTest : public DiagnosticsTest { ...@@ -266,7 +264,7 @@ class PathTest : public DiagnosticsTest {
return true; return true;
} }
} }
if (g_install_type->system_level() && !path_info_.test_writable) { if (!path_info_.test_writable) {
RecordSuccess("Path exists"); RecordSuccess("Path exists");
return true; return true;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment