Commit 08e956e5 authored by Zain Afzal's avatar Zain Afzal Committed by Commit Bot

Add category tag for media app feedback reports.

The media app now has a bucket for feedback (see b/139318556 for more
detail).

This CL adds this bucket id to our invocation of the feedback dialog so
our reports end up in the right place.

Bug: 996088, b/139318556
Change-Id: I30c9cd828c5f71e36f5d45b0603ea8e46b6fcabb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137170Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
Commit-Queue: Zain Afzal <zafzal@google.com>
Cr-Commit-Position: refs/heads/master@{#756916}
parent 808dea13
...@@ -14,15 +14,18 @@ ChromeMediaAppUIDelegate::ChromeMediaAppUIDelegate(content::WebUI* web_ui) ...@@ -14,15 +14,18 @@ ChromeMediaAppUIDelegate::ChromeMediaAppUIDelegate(content::WebUI* web_ui)
base::Optional<std::string> ChromeMediaAppUIDelegate::OpenFeedbackDialog() { base::Optional<std::string> ChromeMediaAppUIDelegate::OpenFeedbackDialog() {
Profile* profile = Profile::FromWebUI(web_ui_); Profile* profile = Profile::FromWebUI(web_ui_);
constexpr char kMediaAppFeedbackCategoryTag[] = "FromMediaApp";
// TODO(crbug/1045222): Additional strings are blank right now while we decide // TODO(crbug/1045222): Additional strings are blank right now while we decide
// on the language and relevant information we want feedback to include. // on the language and relevant information we want feedback to include.
// Note that category_tag is the name of the listnr bucket we want our // Note that category_tag is the name of the listnr bucket we want our
// reports to end up in. I.e DESKTOP_TAB_GROUPS. // reports to end up in.
chrome::ShowFeedbackPage( chrome::ShowFeedbackPage(GURL(chromeos::kChromeUIMediaAppURL), profile,
GURL(chromeos::kChromeUIMediaAppURL), profile, chrome::kFeedbackSourceMediaApp,
chrome::kFeedbackSourceMediaApp, std::string() /* description_template */, std::string() /* description_template */,
std::string() /* description_placeholder_text */, std::string() /* description_placeholder_text */,
std::string() /* category_tag */, std::string() /* extra_diagnostics */); kMediaAppFeedbackCategoryTag /* category_tag */,
std::string() /* extra_diagnostics */);
// TODO(crbug/1048368): Showing the feedback dialog can fail, communicate this // TODO(crbug/1048368): Showing the feedback dialog can fail, communicate this
// back to the client with an error string. For now assume dialog opened. // back to the client with an error string. For now assume dialog opened.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment