Commit 09036974 authored by Peng Huang's avatar Peng Huang Committed by Commit Bot

Remove a DCHECK() which causes crash on macOS

current_frame()->current_render_pass is set in
DirectRenderer::UseRenderPass() for rendering a render pass. However it
is not set back to nullptr, after rendering the render pass. So the
DCHECK() is wrong.

Bug: 1147583
Change-Id: I9d52ce734488802619b1d3935b8edb618a3c070e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536590
Auto-Submit: Peng Huang <penghuang@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: default avatarVasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827250}
parent 585c8f0b
...@@ -2613,7 +2613,6 @@ void SkiaRenderer::PrepareRenderPassOverlay(CALayerOverlay* overlay) { ...@@ -2613,7 +2613,6 @@ void SkiaRenderer::PrepareRenderPassOverlay(CALayerOverlay* overlay) {
// the |current_render_pass| is nullptr during ScheduleOverlays(), since all // the |current_render_pass| is nullptr during ScheduleOverlays(), since all
// overlay quads should be in the |root_render_pass|, before they are promoted // overlay quads should be in the |root_render_pass|, before they are promoted
// to overlays, so set the |root_render_pass| to the |current_render_pass|. // to overlays, so set the |root_render_pass| to the |current_render_pass|.
DCHECK(!current_frame()->current_render_pass);
base::AutoReset<const AggregatedRenderPass*> auto_reset( base::AutoReset<const AggregatedRenderPass*> auto_reset(
&current_frame()->current_render_pass, current_frame()->root_render_pass); &current_frame()->current_render_pass, current_frame()->root_render_pass);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment