Commit 0908c100 authored by Anatoliy Potapchuk's avatar Anatoliy Potapchuk Committed by Commit Bot

Revert "[Settings] Hide Chromevox settings subpage in kiosk mode"

This reverts commit 6eeaad9a.

Reason for revert: ChromeVox settings persistence issue was fixed,
we can show the menu again.

Original change's description:
> [Settings] Hide Chromevox settings subpage in kiosk mode
> 
> We are under discussions about the state of chromevox settings page.
> Let's hide it for now.
> 
> Bug: 1061068
> Change-Id: I21c0f184ee44e5cc9d60b81d731e9dd19148740a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199268
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> Auto-Submit: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#768583}

TBR=khorimoto@chromium.org,apotapchuk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1061068
Change-Id: I0deaab917e26234c2f37d79f07fb34fcc4593928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364632
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarAnatoliy Potapchuk <apotapchuk@chromium.org>
Auto-Submit: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799994}
parent 18651e2c
...@@ -51,13 +51,11 @@ ...@@ -51,13 +51,11 @@
pref="{{prefs.settings.accessibility}}" pref="{{prefs.settings.accessibility}}"
label="$i18n{chromeVoxLabel}"> label="$i18n{chromeVoxLabel}">
</settings-toggle-button> </settings-toggle-button>
<template is="dom-if" if="[[!isKioskModeActive_]]"> <iron-collapse opened="[[prefs.settings.accessibility.value]]">
<iron-collapse opened="[[prefs.settings.accessibility.value]]"> <cr-link-row id="chromeVoxSubpageButton"
<cr-link-row id="chromeVoxSubpageButton" class="settings-box" on-click="onChromeVoxSettingsTap_"
class="settings-box" on-click="onChromeVoxSettingsTap_" label="$i18n{chromeVoxOptionsLabel}" external></cr-link-row>
label="$i18n{chromeVoxOptionsLabel}" external></cr-link-row> </iron-collapse>
</iron-collapse>
</template>
<settings-toggle-button <settings-toggle-button
pref="{{prefs.settings.a11y.select_to_speak}}" pref="{{prefs.settings.a11y.select_to_speak}}"
class="hr" class="hr"
......
...@@ -97,7 +97,9 @@ suite('ManageAccessibilityPageTests', function() { ...@@ -97,7 +97,9 @@ suite('ManageAccessibilityPageTests', function() {
// Accessibility learn more link should be hidden. // Accessibility learn more link should be hidden.
assertFalse(isVisible(page.$$('setings-localized-link'))); assertFalse(isVisible(page.$$('setings-localized-link')));
const allowed_subpages = ['selectToSpeakSubpageButton', 'ttsSubpageButton']; const allowed_subpages = [
'chromeVoxSubpageButton', 'selectToSpeakSubpageButton', 'ttsSubpageButton'
];
const subpages = page.root.querySelectorAll('cr-link-row'); const subpages = page.root.querySelectorAll('cr-link-row');
subpages.forEach(function(subpage) { subpages.forEach(function(subpage) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment