Commit 090ef9ad authored by behdad's avatar behdad Committed by Commit Bot

Removed TRACE_STR_COPY

Coping the strings used in tracing is not necessary because the used
strings are static literals.
Also this is not necessary in case of values
(not category/event/argument names) passed to trace events.

Bug: chromium:1025973
Change-Id: Iabd03e8bf54353663d886c9bb53b7daaa4001919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934772Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719620}
parent 94244152
...@@ -173,8 +173,8 @@ void CompositorFrameReporter::StartStage( ...@@ -173,8 +173,8 @@ void CompositorFrameReporter::StartStage(
CHECK_LT(stage_type_index, static_cast<int>(StageType::kStageTypeCount)); CHECK_LT(stage_type_index, static_cast<int>(StageType::kStageTypeCount));
CHECK_GE(stage_type_index, 0); CHECK_GE(stage_type_index, 0);
TRACE_EVENT_ASYNC_STEP_INTO_WITH_TIMESTAMP0( TRACE_EVENT_ASYNC_STEP_INTO_WITH_TIMESTAMP0(
"cc,benchmark", "PipelineReporter", this, "cc,benchmark", "PipelineReporter", this, GetStageName(stage_type_index),
TRACE_STR_COPY(GetStageName(stage_type_index)), start_time); start_time);
} }
void CompositorFrameReporter::EndCurrentStage(base::TimeTicks end_time) { void CompositorFrameReporter::EndCurrentStage(base::TimeTicks end_time) {
...@@ -257,9 +257,8 @@ void CompositorFrameReporter::TerminateReporter() { ...@@ -257,9 +257,8 @@ void CompositorFrameReporter::TerminateReporter() {
submitted_frame_missed_deadline_ ? "missed_frame" : "non_missed_frame"; submitted_frame_missed_deadline_ ? "missed_frame" : "non_missed_frame";
TRACE_EVENT_ASYNC_END_WITH_TIMESTAMP2( TRACE_EVENT_ASYNC_END_WITH_TIMESTAMP2(
"cc,benchmark", "PipelineReporter", this, frame_termination_time_, "cc,benchmark", "PipelineReporter", this, frame_termination_time_,
"termination_status", TRACE_STR_COPY(termination_status_str), "termination_status", termination_status_str,
"compositor_frame_submission_status", "compositor_frame_submission_status", submission_status_str);
TRACE_STR_COPY(submission_status_str));
// Only report histograms if the frame was presented. // Only report histograms if the frame was presented.
if (report_latency) { if (report_latency) {
......
...@@ -249,7 +249,7 @@ FrameSequenceTracker::FrameSequenceTracker( ...@@ -249,7 +249,7 @@ FrameSequenceTracker::FrameSequenceTracker(
DCHECK_LT(type_, FrameSequenceTrackerType::kMaxType); DCHECK_LT(type_, FrameSequenceTrackerType::kMaxType);
TRACE_EVENT_ASYNC_BEGIN1( TRACE_EVENT_ASYNC_BEGIN1(
"cc,benchmark", "FrameSequenceTracker", this, "name", "cc,benchmark", "FrameSequenceTracker", this, "name",
TRACE_STR_COPY(GetFrameSequenceTrackerTypeName(static_cast<int>(type_)))); GetFrameSequenceTrackerTypeName(static_cast<int>(type_)));
} }
FrameSequenceTracker::~FrameSequenceTracker() { FrameSequenceTracker::~FrameSequenceTracker() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment