Commit 092c5815 authored by Julie Jeongeun Kim's avatar Julie Jeongeun Kim Committed by Commit Bot

Clean up old Mojo types for interfaces from compositor_frame_sink.mojom

This CL cleans up old Mojo types for CompositorFrameSinkClient and
CompositorFrameSink from SynchronousLayerTreeFrameSink and uses
PendingReceiver, Receiver, and PendingRemote instead of them.

Bug: 955171
Change-Id: Id0aa5d5dc2409a1de878764514b599a12dcce46b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935973Reviewed-by: default avatarBo <boliu@chromium.org>
Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#719382}
parent b90ebfb3
...@@ -56,7 +56,7 @@ void MockRenderWidgetHost::ExpectForceEnableZoom(bool enable) { ...@@ -56,7 +56,7 @@ void MockRenderWidgetHost::ExpectForceEnableZoom(bool enable) {
} }
// Mocks out |renderer_compositor_frame_sink_| with a // Mocks out |renderer_compositor_frame_sink_| with a
// CompositorFrameSinkClientPtr bound to // CompositorFrameSinkClient bound to
// |mock_renderer_compositor_frame_sink|. // |mock_renderer_compositor_frame_sink|.
void MockRenderWidgetHost::SetMockRendererCompositorFrameSink( void MockRenderWidgetHost::SetMockRendererCompositorFrameSink(
viz::MockCompositorFrameSinkClient* mock_renderer_compositor_frame_sink) { viz::MockCompositorFrameSinkClient* mock_renderer_compositor_frame_sink) {
......
...@@ -57,7 +57,7 @@ class MockRenderWidgetHost : public RenderWidgetHostImpl { ...@@ -57,7 +57,7 @@ class MockRenderWidgetHost : public RenderWidgetHostImpl {
} }
// Mocks out |renderer_compositor_frame_sink_| with a // Mocks out |renderer_compositor_frame_sink_| with a
// CompositorFrameSinkClientPtr bound to // CompositorFrameSinkClient bound to
// |mock_renderer_compositor_frame_sink|. // |mock_renderer_compositor_frame_sink|.
void SetMockRendererCompositorFrameSink( void SetMockRendererCompositorFrameSink(
viz::MockCompositorFrameSinkClient* mock_renderer_compositor_frame_sink); viz::MockCompositorFrameSinkClient* mock_renderer_compositor_frame_sink);
......
...@@ -150,8 +150,10 @@ SynchronousLayerTreeFrameSink::SynchronousLayerTreeFrameSink( ...@@ -150,8 +150,10 @@ SynchronousLayerTreeFrameSink::SynchronousLayerTreeFrameSink(
std::unique_ptr<viz::BeginFrameSource> synthetic_begin_frame_source, std::unique_ptr<viz::BeginFrameSource> synthetic_begin_frame_source,
SynchronousCompositorRegistry* registry, SynchronousCompositorRegistry* registry,
scoped_refptr<FrameSwapMessageQueue> frame_swap_message_queue, scoped_refptr<FrameSwapMessageQueue> frame_swap_message_queue,
viz::mojom::CompositorFrameSinkPtrInfo compositor_frame_sink_info, mojo::PendingRemote<viz::mojom::CompositorFrameSink>
viz::mojom::CompositorFrameSinkClientRequest client_request) compositor_frame_sink_remote,
mojo::PendingReceiver<viz::mojom::CompositorFrameSinkClient>
client_receiver)
: cc::LayerTreeFrameSink(std::move(context_provider), : cc::LayerTreeFrameSink(std::move(context_provider),
std::move(worker_context_provider), std::move(worker_context_provider),
std::move(compositor_task_runner), std::move(compositor_task_runner),
...@@ -162,9 +164,8 @@ SynchronousLayerTreeFrameSink::SynchronousLayerTreeFrameSink( ...@@ -162,9 +164,8 @@ SynchronousLayerTreeFrameSink::SynchronousLayerTreeFrameSink(
sender_(sender), sender_(sender),
memory_policy_(0u), memory_policy_(0u),
frame_swap_message_queue_(frame_swap_message_queue), frame_swap_message_queue_(frame_swap_message_queue),
unbound_compositor_frame_sink_(std::move(compositor_frame_sink_info)), unbound_compositor_frame_sink_(std::move(compositor_frame_sink_remote)),
unbound_client_(std::move(client_request)), unbound_client_(std::move(client_receiver)),
client_binding_(this),
synthetic_begin_frame_source_(std::move(synthetic_begin_frame_source)), synthetic_begin_frame_source_(std::move(synthetic_begin_frame_source)),
viz_for_webview_enabled_(features::IsUsingVizForWebView()) { viz_for_webview_enabled_(features::IsUsingVizForWebView()) {
DCHECK(registry_); DCHECK(registry_);
...@@ -189,7 +190,7 @@ bool SynchronousLayerTreeFrameSink::BindToClient( ...@@ -189,7 +190,7 @@ bool SynchronousLayerTreeFrameSink::BindToClient(
if (viz_for_webview_enabled_) { if (viz_for_webview_enabled_) {
compositor_frame_sink_.Bind(std::move(unbound_compositor_frame_sink_)); compositor_frame_sink_.Bind(std::move(unbound_compositor_frame_sink_));
client_binding_.Bind(std::move(unbound_client_), compositor_task_runner_); client_receiver_.Bind(std::move(unbound_client_), compositor_task_runner_);
} }
// The SharedBitmapManager is null since software compositing is not supported // The SharedBitmapManager is null since software compositing is not supported
...@@ -265,7 +266,7 @@ void SynchronousLayerTreeFrameSink::DetachFromClient() { ...@@ -265,7 +266,7 @@ void SynchronousLayerTreeFrameSink::DetachFromClient() {
display_ = nullptr; display_ = nullptr;
frame_sink_manager_ = nullptr; frame_sink_manager_ = nullptr;
client_binding_.Close(); client_receiver_.reset();
compositor_frame_sink_.reset(); compositor_frame_sink_.reset();
cc::LayerTreeFrameSink::DetachFromClient(); cc::LayerTreeFrameSink::DetachFromClient();
......
...@@ -27,7 +27,9 @@ ...@@ -27,7 +27,9 @@
#include "components/viz/service/display/display_client.h" #include "components/viz/service/display/display_client.h"
#include "components/viz/service/display_embedder/server_shared_bitmap_manager.h" #include "components/viz/service/display_embedder/server_shared_bitmap_manager.h"
#include "ipc/ipc_message.h" #include "ipc/ipc_message.h"
#include "mojo/public/cpp/bindings/binding.h" #include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/pending_remote.h"
#include "mojo/public/cpp/bindings/receiver.h"
#include "services/viz/public/mojom/compositing/compositor_frame_sink.mojom.h" #include "services/viz/public/mojom/compositing/compositor_frame_sink.mojom.h"
#include "ui/gfx/transform.h" #include "ui/gfx/transform.h"
...@@ -90,8 +92,10 @@ class SynchronousLayerTreeFrameSink ...@@ -90,8 +92,10 @@ class SynchronousLayerTreeFrameSink
std::unique_ptr<viz::BeginFrameSource> begin_frame_source, std::unique_ptr<viz::BeginFrameSource> begin_frame_source,
SynchronousCompositorRegistry* registry, SynchronousCompositorRegistry* registry,
scoped_refptr<FrameSwapMessageQueue> frame_swap_message_queue, scoped_refptr<FrameSwapMessageQueue> frame_swap_message_queue,
viz::mojom::CompositorFrameSinkPtrInfo compositor_frame_sink_info, mojo::PendingRemote<viz::mojom::CompositorFrameSink>
viz::mojom::CompositorFrameSinkClientRequest client_request); compositor_frame_sink_remote,
mojo::PendingReceiver<viz::mojom::CompositorFrameSinkClient>
client_receiver);
~SynchronousLayerTreeFrameSink() override; ~SynchronousLayerTreeFrameSink() override;
void SetSyncClient(SynchronousLayerTreeFrameSinkClient* compositor); void SetSyncClient(SynchronousLayerTreeFrameSinkClient* compositor);
...@@ -174,10 +178,11 @@ class SynchronousLayerTreeFrameSink ...@@ -174,10 +178,11 @@ class SynchronousLayerTreeFrameSink
bool fallback_tick_pending_ = false; bool fallback_tick_pending_ = false;
bool fallback_tick_running_ = false; bool fallback_tick_running_ = false;
viz::mojom::CompositorFrameSinkPtrInfo unbound_compositor_frame_sink_; mojo::PendingRemote<viz::mojom::CompositorFrameSink>
viz::mojom::CompositorFrameSinkClientRequest unbound_client_; unbound_compositor_frame_sink_;
mojo::PendingReceiver<viz::mojom::CompositorFrameSinkClient> unbound_client_;
viz::mojom::CompositorFrameSinkPtr compositor_frame_sink_; viz::mojom::CompositorFrameSinkPtr compositor_frame_sink_;
mojo::Binding<viz::mojom::CompositorFrameSinkClient> client_binding_; mojo::Receiver<viz::mojom::CompositorFrameSinkClient> client_receiver_{this};
viz::LocalSurfaceId local_surface_id_; viz::LocalSurfaceId local_surface_id_;
class StubDisplayClient : public viz::DisplayClient { class StubDisplayClient : public viz::DisplayClient {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment