Commit 09489a7f authored by Kevin Marshall's avatar Kevin Marshall Committed by Commit Bot

Fuchsia: Emit JS console log metadata with logging lines.

There is a bug which causes the JS logging code to emit logging lines
without file and line information.

This fix outputs the full formatted line to stdout instead.

Change-Id: Icbb10da6d5d1d1db6b749495dd358c1b87c2ae5c
Reviewed-on: https://chromium-review.googlesource.com/c/1357653Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612892}
parent ad3dc556
...@@ -442,19 +442,19 @@ bool FrameImpl::DidAddMessageToConsole(content::WebContents* source, ...@@ -442,19 +442,19 @@ bool FrameImpl::DidAddMessageToConsole(content::WebContents* source,
switch (level) { switch (level) {
case static_cast<std::underlying_type<chromium::web::LogLevel>::type>( case static_cast<std::underlying_type<chromium::web::LogLevel>::type>(
chromium::web::LogLevel::DEBUG): chromium::web::LogLevel::DEBUG):
LOG(INFO) << "debug:" << message; LOG(INFO) << "debug:" << message_formatted;
break; break;
case static_cast<std::underlying_type<chromium::web::LogLevel>::type>( case static_cast<std::underlying_type<chromium::web::LogLevel>::type>(
chromium::web::LogLevel::INFO): chromium::web::LogLevel::INFO):
LOG(INFO) << "info:" << message; LOG(INFO) << "info:" << message_formatted;
break; break;
case static_cast<std::underlying_type<chromium::web::LogLevel>::type>( case static_cast<std::underlying_type<chromium::web::LogLevel>::type>(
chromium::web::LogLevel::WARN): chromium::web::LogLevel::WARN):
LOG(WARNING) << "warn:" << message; LOG(WARNING) << "warn:" << message_formatted;
break; break;
case static_cast<std::underlying_type<chromium::web::LogLevel>::type>( case static_cast<std::underlying_type<chromium::web::LogLevel>::type>(
chromium::web::LogLevel::ERROR): chromium::web::LogLevel::ERROR):
LOG(ERROR) << "error:" << message; LOG(ERROR) << "error:" << message_formatted;
break; break;
default: default:
DLOG(WARNING) << "Unknown log level: " << level; DLOG(WARNING) << "Unknown log level: " << level;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment