Commit 098d5274 authored by erikchen's avatar erikchen Committed by Commit bot

Add more CALayerResult histograms

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2162683002
Cr-Commit-Position: refs/heads/master@{#406130}
parent d2e8909b
......@@ -35,6 +35,8 @@ enum CALayerResult {
CA_LAYER_FAILED_RENDER_PASS,
CA_LAYER_FAILED_SURFACE_CONTENT,
CA_LAYER_FAILED_YUV_VIDEO_CONTENT,
CA_LAYER_FAILED_DIFFERENT_CLIP_SETTINGS,
CA_LAYER_FAILED_DIFFERENT_VERTEX_OPACITIES,
CA_LAYER_FAILED_COUNT,
};
......@@ -86,7 +88,7 @@ CALayerResult FromTextureQuad(ResourceProvider* resource_provider,
ca_layer_overlay->background_color = quad->background_color;
for (int i = 1; i < 4; ++i) {
if (quad->vertex_opacity[i] != quad->vertex_opacity[0])
return CA_LAYER_FAILED_UNKNOWN;
return CA_LAYER_FAILED_DIFFERENT_VERTEX_OPACITIES;
}
ca_layer_overlay->opacity *= quad->vertex_opacity[0];
ca_layer_overlay->filter = quad->nearest_neighbor ? GL_NEAREST : GL_LINEAR;
......@@ -210,8 +212,7 @@ bool ProcessForCALayerOverlays(ResourceProvider* resource_provider,
previous_ca_layer.sorting_context_id == ca_layer.sorting_context_id) {
if (previous_ca_layer.is_clipped != ca_layer.is_clipped ||
previous_ca_layer.clip_rect != ca_layer.clip_rect) {
// TODO(ccameron): Add a histogram value for this.
result = CA_LAYER_FAILED_UNKNOWN;
result = CA_LAYER_FAILED_DIFFERENT_CLIP_SETTINGS;
break;
}
}
......
......@@ -67918,6 +67918,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="13" label="RenderPass quads not supported"/>
<int value="14" label="SurfaceContent quads not supported"/>
<int value="15" label="YUVVideo quads not supported"/>
<int value="16"
label="Different clip settings in a sorting context is not supported."/>
<int value="17"
label="Different vertex opacities for a single texture is not supported"/>
</enum>
<enum name="CanvasContextType" type="int">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment