Commit 0990468b authored by clemensh's avatar clemensh Committed by Commit bot

[LayoutTests] Remove line and column of evaluate function

We had to rebaseline a test several times just because the script on V8
side changed. Excluding the position information of the evaluate
method avoids this in the future.

BUG=656622,652939
R=kozyatinskiy@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2440293002
Cr-Commit-Position: refs/heads/master@{#427300}
parent cd641116
...@@ -996,8 +996,6 @@ crbug.com/249112 imported/csswg-test/css-flexbox-1/flex-minimum-height-flex-item ...@@ -996,8 +996,6 @@ crbug.com/249112 imported/csswg-test/css-flexbox-1/flex-minimum-height-flex-item
crbug.com/249112 imported/csswg-test/css-flexbox-1/flex-minimum-width-flex-items-005.xht [ Failure ] crbug.com/249112 imported/csswg-test/css-flexbox-1/flex-minimum-width-flex-items-005.xht [ Failure ]
crbug.com/249112 imported/csswg-test/css-flexbox-1/flex-minimum-width-flex-items-007.xht [ Failure ] crbug.com/249112 imported/csswg-test/css-flexbox-1/flex-minimum-width-flex-items-007.xht [ Failure ]
crbug.com/656622 inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html [ NeedsManualRebaseline ]
# Not implemented yet # Not implemented yet
crbug.com/336604 imported/csswg-test/css-flexbox-1/flexbox_visibility-collapse-line-wrapping.html [ Failure ] crbug.com/336604 imported/csswg-test/css-flexbox-1/flexbox_visibility-collapse-line-wrapping.html [ Failure ]
crbug.com/336604 imported/csswg-test/css-flexbox-1/flexbox_visibility-collapse.html [ Failure ] crbug.com/336604 imported/csswg-test/css-flexbox-1/flexbox_visibility-collapse.html [ Failure ]
......
...@@ -54,6 +54,9 @@ InspectorTest.prepareConsoleMessageText = function(messageElement, consoleMessag ...@@ -54,6 +54,9 @@ InspectorTest.prepareConsoleMessageText = function(messageElement, consoleMessag
var messageText = messageElement.deepTextContent().replace(/\u200b/g, ""); var messageText = messageElement.deepTextContent().replace(/\u200b/g, "");
// Replace scriptIds with generic scriptId string to avoid flakiness. // Replace scriptIds with generic scriptId string to avoid flakiness.
messageText = messageText.replace(/VM\d+/g, "VM"); messageText = messageText.replace(/VM\d+/g, "VM");
// Remove line and column of evaluate method.
messageText = messageText.replace(/(at eval \(eval at evaluate) \(:\d+:\d+\)/, '$1');
if (messageText.startsWith("Navigated to")) { if (messageText.startsWith("Navigated to")) {
var fileName = messageText.split(" ").pop().split("/").pop(); var fileName = messageText.split(" ").pop().split("/").pop();
messageText = "Navigated to " + fileName; messageText = "Navigated to " + fileName;
......
...@@ -7,7 +7,7 @@ injectedFunction() ...@@ -7,7 +7,7 @@ injectedFunction()
VM:6 Uncaught Error: injectedObj.func VM:6 Uncaught Error: injectedObj.func
at Object.func (<anonymous>:6:23) at Object.func (<anonymous>:6:23)
at injectedFunction (<anonymous>:9:28) at injectedFunction (<anonymous>:9:28)
at eval (eval at evaluate (:111:21), <anonymous>:1:1) at eval (eval at evaluate, <anonymous>:1:1)
at testFunction (test.js:23:5) at testFunction (test.js:23:5)
func @ VM:6 func @ VM:6
injectedFunction @ VM:9 injectedFunction @ VM:9
...@@ -16,7 +16,7 @@ testFunction @ test.js:18 ...@@ -16,7 +16,7 @@ testFunction @ test.js:18
localObj.func() localObj.func()
test.js:15 Uncaught Error: localObj.func test.js:15 Uncaught Error: localObj.func
at Object.func (test.js:20:19) at Object.func (test.js:20:19)
at eval (eval at evaluate (:111:21), <anonymous>:1:10) at eval (eval at evaluate, <anonymous>:1:10)
at testFunction (test.js:23:5) at testFunction (test.js:23:5)
func @ test.js:15 func @ test.js:15
(anonymous) @ VM:1 (anonymous) @ VM:1
...@@ -24,7 +24,7 @@ testFunction @ test.js:18 ...@@ -24,7 +24,7 @@ testFunction @ test.js:18
globalObj.func() globalObj.func()
test.js:6 Uncaught Error: globalObj.func test.js:6 Uncaught Error: globalObj.func
at Object.func (test.js:11:15) at Object.func (test.js:11:15)
at eval (eval at evaluate (:111:21), <anonymous>:1:11) at eval (eval at evaluate, <anonymous>:1:11)
at testFunction (test.js:23:5) at testFunction (test.js:23:5)
func @ test.js:6 func @ test.js:6
(anonymous) @ VM:1 (anonymous) @ VM:1
......
Tests that evaluation in console that throws works fine when script is paused.
Set timer for test function.
Dumping console messages:
injectedFunction()
VM:6 Uncaught Error: injectedObj.func
at Object.func (<anonymous>:6:23)
at injectedFunction (<anonymous>:9:28)
at eval (eval at evaluate (:117:21), <anonymous>:1:1)
at testFunction (test.js:23:5)
func @ VM:6
injectedFunction @ VM:9
(anonymous) @ VM:1
testFunction @ test.js:18
localObj.func()
test.js:15 Uncaught Error: localObj.func
at Object.func (test.js:20:19)
at eval (eval at evaluate (:117:21), <anonymous>:1:10)
at testFunction (test.js:23:5)
func @ test.js:15
(anonymous) @ VM:1
testFunction @ test.js:18
globalObj.func()
test.js:6 Uncaught Error: globalObj.func
at Object.func (test.js:11:15)
at eval (eval at evaluate (:117:21), <anonymous>:1:11)
at testFunction (test.js:23:5)
func @ test.js:6
(anonymous) @ VM:1
testFunction @ test.js:18
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment