Commit 09ac2636 authored by Jae Hoon Kim's avatar Jae Hoon Kim Committed by Commit Bot

Replace DBus method constant with system_api constant

"GetExistingDlcs" DBus method constant is in system_api now and can be
used within dlcservice client files.

BUG=none
TEST=./unit_tests

Change-Id: I347fbabef4691f69ec3482ffbf51cbe7c9b54c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199679
Auto-Submit: Jae Hoon Kim <kimjae@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768511}
parent 6a3eb147
...@@ -37,9 +37,6 @@ namespace chromeos { ...@@ -37,9 +37,6 @@ namespace chromeos {
namespace { namespace {
// TODO(kimjae): Delete and remove usages once system_api is uprev'ed.
const char kGetExistingDlcsMethod[] = "GetExistingDlcs";
DlcserviceClient* g_instance = nullptr; DlcserviceClient* g_instance = nullptr;
class DlcserviceErrorResponseHandler { class DlcserviceErrorResponseHandler {
...@@ -192,9 +189,8 @@ class DlcserviceClientImpl : public DlcserviceClient { ...@@ -192,9 +189,8 @@ class DlcserviceClientImpl : public DlcserviceClient {
} }
TaskStarted(); TaskStarted();
// TODO(kimjae): Use |kGetExistingDlcsMethod| once system_api is uprev'ed.
dbus::MethodCall method_call(dlcservice::kDlcServiceInterface, dbus::MethodCall method_call(dlcservice::kDlcServiceInterface,
kGetExistingDlcsMethod); dlcservice::kGetExistingDlcsMethod);
VLOG(1) << "Requesting to get existing DLC(s)."; VLOG(1) << "Requesting to get existing DLC(s).";
dlcservice_proxy_->CallMethodWithErrorResponse( dlcservice_proxy_->CallMethodWithErrorResponse(
......
...@@ -125,9 +125,8 @@ TEST_F(DlcserviceClientTest, GetExistingDlcsSuccessTest) { ...@@ -125,9 +125,8 @@ TEST_F(DlcserviceClientTest, GetExistingDlcsSuccessTest) {
} }
TEST_F(DlcserviceClientTest, GetExistingDlcsFailureTest) { TEST_F(DlcserviceClientTest, GetExistingDlcsFailureTest) {
// TODO(kimjae): Use |kGetExistingDlcsMethod| once system_api is uprev'ed.
dbus::MethodCall method_call(dlcservice::kDlcServiceInterface, dbus::MethodCall method_call(dlcservice::kDlcServiceInterface,
"GetExsitingDlcs"); dlcservice::kGetExistingDlcsMethod);
method_call.SetSerial(123); method_call.SetSerial(123);
err_responses_.push_back(dbus::ErrorResponse::FromMethodCall( err_responses_.push_back(dbus::ErrorResponse::FromMethodCall(
&method_call, DBUS_ERROR_FAILED, "some-unknown-error")); &method_call, DBUS_ERROR_FAILED, "some-unknown-error"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment