Skip to content

GitLab

T
tangled
Commit 09d231c7 authored by Jose Dapena Paz's avatar Jose Dapena Paz Committed by Commit Bot
Browse files
Options

Removed CSSStickyPosition runtime flag. 

CSSStickyPosition runtime flag has been shipped as stable from at least
m56. This patch removes the flag and make the dependent code
unconditional.

BUG=402536

Change-Id: I325da511415dd2d7aad7b1602e32bc8205489ac0
Reviewed-on: https://chromium-review.googlesource.com/738773Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarEric Willigers <ericwilligers@chromium.org>
Reviewed-by: default avatarmeade_UTC10 <meade@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512771}
parent 37843401
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 146 deletions
third_party/WebKit/LayoutTests/fast/css/sticky/inline-sticky-abspos-child.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/inline-sticky-anonymous-container.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<style> <style>
body { body {
height: 2000px; height: 2000px;
......
third_party/WebKit/LayoutTests/fast/css/sticky/remove-inline-sticky-crash.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/remove-sticky-crash.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/replaced-sticky.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-as-positioning-container.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-both-sides-bottom-right-constrained.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-both-sides-top-left-constrained.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-container-moved.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<style> <style>
body { body {
margin: 0; margin: 0;
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-display-expected.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-display.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-ltr.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-horizontally-overconstrained-rtl.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-html-crash.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<style> <style>
html { html {
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-margin-changed.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<style> <style>
.scroller { .scroller {
background-color: red; background-color: red;
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-overflow-changed.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<style> <style>
body { body {
margin: 0; margin: 0;
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-overflowing.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-position-works-with-scroll-apis.html
View file @ 09d231c7
...@@ -35,10 +35,6 @@ body { ...@@ -35,10 +35,6 @@ body {
</div> </div>
<script> <script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
// These tests currently mimic the behavior of Firefox for the interaction // These tests currently mimic the behavior of Firefox for the interaction
// between scrollIntoView() and position:sticky, where the offset location of // between scrollIntoView() and position:sticky, where the offset location of
// the sticky element is used to determine how far to scroll. This means that // the sticky element is used to determine how far to scroll. This means that
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-style-change.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-table-col-crash.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<script> <script>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-overflow-scroll-by-fragment.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<script> <script>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-top-overflow.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/LayoutTests/fast/css/sticky/sticky-vertically-overconstrained.html
View file @ 09d231c7
<!DOCTYPE html> <!DOCTYPE html>
<script>
if (window.internals) {
internals.settings.setCSSStickyPositionEnabled(true);
}
</script>
<html> <html>
<head> <head>
<style> <style>
......
third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
View file @ 09d231c7
...@@ -641,8 +641,7 @@ bool CSSParserFastPaths::IsValidKeywordPropertyAndValue( ...@@ -641,8 +641,7 @@ bool CSSParserFastPaths::IsValidKeywordPropertyAndValue(
case CSSPropertyPosition: case CSSPropertyPosition:
return value_id == CSSValueStatic || value_id == CSSValueRelative || return value_id == CSSValueStatic || value_id == CSSValueRelative ||
value_id == CSSValueAbsolute || value_id == CSSValueFixed || value_id == CSSValueAbsolute || value_id == CSSValueFixed ||
(RuntimeEnabledFeatures::CSSStickyPositionEnabled() && value_id == CSSValueSticky;
value_id == CSSValueSticky);
case CSSPropertyResize: case CSSPropertyResize:
return value_id == CSSValueNone || value_id == CSSValueBoth || return value_id == CSSValueNone || value_id == CSSValueBoth ||
value_id == CSSValueHorizontal || value_id == CSSValueVertical || value_id == CSSValueHorizontal || value_id == CSSValueVertical ||
......
third_party/WebKit/Source/core/testing/InternalSettings.cpp
View file @ 09d231c7
...@@ -60,8 +60,6 @@ namespace blink { ...@@ -60,8 +60,6 @@ namespace blink {
InternalSettings::Backup::Backup(Settings* settings) InternalSettings::Backup::Backup(Settings* settings)
: original_csp_(RuntimeEnabledFeatures:: : original_csp_(RuntimeEnabledFeatures::
ExperimentalContentSecurityPolicyFeaturesEnabled()), ExperimentalContentSecurityPolicyFeaturesEnabled()),
original_css_sticky_position_enabled_(
RuntimeEnabledFeatures::CSSStickyPositionEnabled()),
original_overlay_scrollbars_enabled_( original_overlay_scrollbars_enabled_(
RuntimeEnabledFeatures::OverlayScrollbarsEnabled()), RuntimeEnabledFeatures::OverlayScrollbarsEnabled()),
original_editing_behavior_(settings->GetEditingBehaviorType()), original_editing_behavior_(settings->GetEditingBehaviorType()),
...@@ -88,8 +86,6 @@ InternalSettings::Backup::Backup(Settings* settings) ...@@ -88,8 +86,6 @@ InternalSettings::Backup::Backup(Settings* settings)
void InternalSettings::Backup::RestoreTo(Settings* settings) { void InternalSettings::Backup::RestoreTo(Settings* settings) {
RuntimeEnabledFeatures::SetExperimentalContentSecurityPolicyFeaturesEnabled( RuntimeEnabledFeatures::SetExperimentalContentSecurityPolicyFeaturesEnabled(
original_csp_); original_csp_);
RuntimeEnabledFeatures::SetCSSStickyPositionEnabled(
original_css_sticky_position_enabled_);
RuntimeEnabledFeatures::SetOverlayScrollbarsEnabled( RuntimeEnabledFeatures::SetOverlayScrollbarsEnabled(
original_overlay_scrollbars_enabled_); original_overlay_scrollbars_enabled_);
settings->SetEditingBehaviorType(original_editing_behavior_); settings->SetEditingBehaviorType(original_editing_behavior_);
...@@ -166,10 +162,6 @@ void InternalSettings::setMockGestureTapHighlightsEnabled( ...@@ -166,10 +162,6 @@ void InternalSettings::setMockGestureTapHighlightsEnabled(
GetSettings()->SetMockGestureTapHighlightsEnabled(enabled); GetSettings()->SetMockGestureTapHighlightsEnabled(enabled);
} }
void InternalSettings::setCSSStickyPositionEnabled(bool enabled) {
RuntimeEnabledFeatures::SetCSSStickyPositionEnabled(enabled);
}
void InternalSettings::setExperimentalContentSecurityPolicyFeaturesEnabled( void InternalSettings::setExperimentalContentSecurityPolicyFeaturesEnabled(
bool enabled) { bool enabled) {
RuntimeEnabledFeatures::SetExperimentalContentSecurityPolicyFeaturesEnabled( RuntimeEnabledFeatures::SetExperimentalContentSecurityPolicyFeaturesEnabled(
......
third_party/WebKit/Source/core/testing/InternalSettings.h
View file @ 09d231c7
...@@ -57,7 +57,6 @@ class InternalSettings final : public InternalSettingsGenerated, ...@@ -57,7 +57,6 @@ class InternalSettings final : public InternalSettingsGenerated,
void RestoreTo(Settings*); void RestoreTo(Settings*);
bool original_csp_; bool original_csp_;
bool original_css_sticky_position_enabled_;
bool original_overlay_scrollbars_enabled_; bool original_overlay_scrollbars_enabled_;
EditingBehaviorType original_editing_behavior_; EditingBehaviorType original_editing_behavior_;
bool original_text_autosizing_enabled_; bool original_text_autosizing_enabled_;
...@@ -131,7 +130,6 @@ class InternalSettings final : public InternalSettingsGenerated, ...@@ -131,7 +130,6 @@ class InternalSettings final : public InternalSettingsGenerated,
// FIXME: The following are RuntimeEnabledFeatures and likely // FIXME: The following are RuntimeEnabledFeatures and likely
// cannot be changed after process start. These setters should // cannot be changed after process start. These setters should
// be removed or moved onto internals.runtimeFlags: // be removed or moved onto internals.runtimeFlags:
void setCSSStickyPositionEnabled(bool);
void setLangAttributeAwareFormControlUIEnabled(bool); void setLangAttributeAwareFormControlUIEnabled(bool);
void setOverlayScrollbarsEnabled(bool); void setOverlayScrollbarsEnabled(bool);
void setExperimentalContentSecurityPolicyFeaturesEnabled(bool); void setExperimentalContentSecurityPolicyFeaturesEnabled(bool);
......
third_party/WebKit/Source/core/testing/InternalSettings.idl
View file @ 09d231c7
...@@ -59,7 +59,6 @@ interface InternalSettings : InternalSettingsGenerated { ...@@ -59,7 +59,6 @@ interface InternalSettings : InternalSettingsGenerated {
// FIXME: The following are RuntimeEnabledFeatures and likely // FIXME: The following are RuntimeEnabledFeatures and likely
// cannot be changed after process start. These setters should // cannot be changed after process start. These setters should
// be removed or moved onto internals.runtimeFlags: // be removed or moved onto internals.runtimeFlags:
void setCSSStickyPositionEnabled(boolean enabled);
void setLangAttributeAwareFormControlUIEnabled(boolean enabled); void setLangAttributeAwareFormControlUIEnabled(boolean enabled);
void setOverlayScrollbarsEnabled(boolean enabled); void setOverlayScrollbarsEnabled(boolean enabled);
void setExperimentalContentSecurityPolicyFeaturesEnabled(boolean enabled); void setExperimentalContentSecurityPolicyFeaturesEnabled(boolean enabled);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment