[Autofill Assistant] Fix for sticky buttons not always showing

Bug: b/156707484
Change-Id: I4903aadb5e1b2d8455c868b07c2abcca874e7c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352822
Commit-Queue: Michele Mancina <micantox@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#798565}

chrome/android/features/autofill_assistant/java/src/org/chromium/chrome/browser/autofill_assistant/AssistantBottomBarCoordinator.java

@@ -265,7 +265,12 @@ class AssistantBottomBarCoordinator implements AssistantPeekHeightCoordinator.De
         model.getHeaderModel().addObserver((source, propertyKey) -> {
             if (propertyKey == AssistantHeaderModel.CHIPS_VISIBLE
                     || propertyKey == AssistantHeaderModel.CHIPS) {
-                animateChildren(rootView);
+                // The PostTask is necessary as a workaround for the sticky button occasionally not
+                // showing, since the chip changes are now issued in the following UI iteration, the
+                // same needs to be done for the corresponding animations.
+                // TODO(b/164389932): Figure out a better fix that doesn't require issuing the
+                // change in the following UI iteration.
+                PostTask.postTask(UiThreadTaskTraits.DEFAULT, () -> animateChildren(rootView));
             }
         });
 

chrome/android/features/autofill_assistant/java/src/org/chromium/chrome/browser/autofill_assistant/header/AssistantHeaderViewBinder.java

@@ -14,6 +14,7 @@ import androidx.annotation.Nullable;
 import androidx.recyclerview.widget.DefaultItemAnimator;
 import androidx.recyclerview.widget.RecyclerView;
 
+import org.chromium.base.task.PostTask;
 import org.chromium.chrome.autofill_assistant.R;
 import org.chromium.chrome.browser.autofill_assistant.AssistantTextUtils;
 import org.chromium.chrome.browser.autofill_assistant.carousel.AssistantChipAdapter;
@@ -22,6 +23,7 @@ import org.chromium.chrome.browser.settings.SettingsLauncherImpl;
 import org.chromium.chrome.browser.sync.settings.SyncAndServicesSettings;
 import org.chromium.chrome.browser.util.ChromeAccessibilityUtil;
 import org.chromium.components.browser_ui.widget.textbubble.TextBubble;
+import org.chromium.content_public.browser.UiThreadTaskTraits;
 import org.chromium.ui.modelutil.PropertyKey;
 import org.chromium.ui.modelutil.PropertyModelChangeProcessor;
 import org.chromium.ui.widget.ViewRectProvider;
@@ -134,15 +136,21 @@ class AssistantHeaderViewBinder
     }
 
     private void maybeShowChips(AssistantHeaderModel model, ViewHolder view) {
-        if (model.get(AssistantHeaderModel.CHIPS_VISIBLE)
-                && !model.get(AssistantHeaderModel.CHIPS).isEmpty()) {
-            view.mChipsContainer.setVisibility(View.VISIBLE);
-            view.mProfileIconView.setVisibility(View.GONE);
-        } else {
-            view.mChipsContainer.setVisibility(View.GONE);
-
-            view.mProfileIconView.setVisibility(View.VISIBLE);
-        }
+        // The PostTask is necessary as a workaround for the sticky button occasionally not showing,
+        // this makes sure that the change happens after any possibly clashing animation currently
+        // happening.
+        // TODO(b/164389932): Figure out a better fix that doesn't require issuing the change in the
+        // following UI iteration.
+        PostTask.postTask(UiThreadTaskTraits.DEFAULT, () -> {
+            if (model.get(AssistantHeaderModel.CHIPS_VISIBLE)
+                    && !model.get(AssistantHeaderModel.CHIPS).isEmpty()) {
+                view.mChipsContainer.setVisibility(View.VISIBLE);
+                view.mProfileIconView.setVisibility(View.GONE);
+            } else {
+                view.mChipsContainer.setVisibility(View.GONE);
+                view.mProfileIconView.setVisibility(View.VISIBLE);
+            }
+        });
     }
 
     private void setProfileMenuListener(ViewHolder view, @Nullable Runnable feedbackCallback) {