Commit 0a524a13 authored by Sajjad Mirza's avatar Sajjad Mirza Committed by Commit Bot

[code coverage] Check for coverage build before removing default deps.

This fixes link-time undefined symbol errors that occur because the
Clang profiling runtime uses symbols from the C runtime.

Bug: 1020445
Change-Id: Ic7b1f9cb970ff26592a934675ee5bc204249f4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896238Reviewed-by: default avatarTien Mai <tienmai@chromium.org>
Reviewed-by: default avatarRoger Tawa <rogerta@chromium.org>
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713282}
parent 1f95733f
...@@ -28,7 +28,7 @@ shared_library("gcp_eventlog_provider") { ...@@ -28,7 +28,7 @@ shared_library("gcp_eventlog_provider") {
"gcp_eventlog_provider.cc", "gcp_eventlog_provider.cc",
] ]
if (!is_asan) { if (!is_asan && !use_clang_coverage) {
no_default_deps = true no_default_deps = true
ldflags = [ "/NOENTRY" ] ldflags = [ "/NOENTRY" ]
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment