Skip to content

GitLab

T
tangled
Commit 0a6a2262 authored by tapted's avatar tapted Committed by Commit bot
Browse files
Options

Disable flaky subset of TopControlsManagerTest.* 

failures on Win x64:
TopControlsManagerTest.PinchBeginStartsAnimationIfNecessary
TopControlsManagerTest.PartialShownHideAnimation
TopControlsManagerTest.PartialShownWithAmbiguousThresholdHides

Errors like
TopControlsManagerTest.PartialShownHideAnimation (run #1):
[ RUN      ] TopControlsManagerTest.PartialShownHideAnimation
top_controls_manager_unittest.cc(160): error: Expected: (manager->ControlsTopOffset()) \u003C (previous_offset), actual: -100 vs -100
[  FAILED  ] TopControlsManagerTest.PartialShownHideAnimation (0 ms)

Likely became flaky in r315216.

BUG=456617
TBR=aelias@chromium.org

Review URL: https://codereview.chromium.org/906103002

Cr-Commit-Position: refs/heads/master@{#315248}
parent c3548e1b
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 3 deletions
cc/input/top_controls_manager_unittest.cc
View file @ 0a6a2262
...@@ -135,7 +135,8 @@ TEST(TopControlsManagerTest, EnsureScrollThresholdApplied) { ...@@ -135,7 +135,8 @@ TEST(TopControlsManagerTest, EnsureScrollThresholdApplied) {
manager->ScrollEnd(); manager->ScrollEnd();
} }
TEST(TopControlsManagerTest, PartialShownHideAnimation) { // Flaky. See http://crbug.com/456617.
TEST(TopControlsManagerTest, DISABLED_PartialShownHideAnimation) {
MockTopControlsManagerClient client(100.f, 0.5f, 0.5f); MockTopControlsManagerClient client(100.f, 0.5f, 0.5f);
TopControlsManager* manager = client.manager(); TopControlsManager* manager = client.manager();
manager->ScrollBegin(); manager->ScrollBegin();
...@@ -221,7 +222,9 @@ TEST(TopControlsManagerTest, PartialHiddenWithAmbiguousThresholdShows) { ...@@ -221,7 +222,9 @@ TEST(TopControlsManagerTest, PartialHiddenWithAmbiguousThresholdShows) {
EXPECT_FLOAT_EQ(100.f, manager->ContentTopOffset()); EXPECT_FLOAT_EQ(100.f, manager->ContentTopOffset());
} }
TEST(TopControlsManagerTest, PartialHiddenWithAmbiguousThresholdHides) { // Flaky. See http://crbug.com/456617.
TEST(TopControlsManagerTest,
DISABLED_PartialHiddenWithAmbiguousThresholdHides) {
MockTopControlsManagerClient client(100.f, 0.25f, 0.25f); MockTopControlsManagerClient client(100.f, 0.25f, 0.25f);
TopControlsManager* manager = client.manager(); TopControlsManager* manager = client.manager();
...@@ -336,7 +339,8 @@ TEST(TopControlsManagerTest, PinchIgnoresScroll) { ...@@ -336,7 +339,8 @@ TEST(TopControlsManagerTest, PinchIgnoresScroll) {
EXPECT_TRUE(manager->animation()); EXPECT_TRUE(manager->animation());
} }
TEST(TopControlsManagerTest, PinchBeginStartsAnimationIfNecessary) { // Flaky. See http://crbug.com/456617.
TEST(TopControlsManagerTest, DISABLED_PinchBeginStartsAnimationIfNecessary) {
MockTopControlsManagerClient client(100.f, 0.5f, 0.5f); MockTopControlsManagerClient client(100.f, 0.5f, 0.5f);
TopControlsManager* manager = client.manager(); TopControlsManager* manager = client.manager();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment