Commit 0aa1fe6e authored by Martin Barbella's avatar Martin Barbella Committed by Commit Bot

[UBSan] Enable builtin and bounds checks.

Bounds was previously disabled due to an UBSan bug that caused problems in yasm, but this no longer reproduces.

Change-Id: I3e06cea5ce51ff44ecc2171c05ceea29a40ec83b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906905
Commit-Queue: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: default avatarAbhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714357}
parent 7cbfbf9a
...@@ -486,9 +486,9 @@ config("ubsan_flags") { ...@@ -486,9 +486,9 @@ config("ubsan_flags") {
rebase_path("//tools/ubsan/blacklist.txt", root_build_dir) rebase_path("//tools/ubsan/blacklist.txt", root_build_dir)
} }
cflags += [ cflags += [
# Yasm dies with an "Illegal instruction" error when bounds checking is "-fsanitize=bool",
# enabled. See http://crbug.com/489901 "-fsanitize=bounds",
# "-fsanitize=bounds", "-fsanitize=builtin",
"-fsanitize=float-divide-by-zero", "-fsanitize=float-divide-by-zero",
"-fsanitize=integer-divide-by-zero", "-fsanitize=integer-divide-by-zero",
"-fsanitize=null", "-fsanitize=null",
...@@ -500,7 +500,6 @@ config("ubsan_flags") { ...@@ -500,7 +500,6 @@ config("ubsan_flags") {
"-fsanitize=signed-integer-overflow", "-fsanitize=signed-integer-overflow",
"-fsanitize=unreachable", "-fsanitize=unreachable",
"-fsanitize=vla-bound", "-fsanitize=vla-bound",
"-fsanitize=bool",
"-fsanitize-blacklist=$ubsan_blacklist_path", "-fsanitize-blacklist=$ubsan_blacklist_path",
] ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment