Commit 0aa87c0b authored by Hector Carmona's avatar Hector Carmona Committed by Commit Bot

Navi: Add finch options for app and shortcut variation.

Bug: 967785
Change-Id: I12c99470ed982adee57dc5f73b109fda618ba379
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636275Reviewed-by: default avatarJesse Doherty <jwd@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664907}
parent 781ed227
......@@ -98,6 +98,20 @@ bool CanShowSigninModuleForTesting(const policy::PolicyMap& policies) {
return CanShowSigninModule(policies);
}
#if defined(GOOGLE_CHROME_BUILD) && defined(OS_WIN)
// These feature flags are used to tie our experiment to specific studies.
// go/navi-app-variation for details.
// TODO(hcarmona): find a solution that scales better.
const base::Feature kNaviControlEnabled = {"NaviControlEnabled",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kNaviAppVariationEnabled = {
"NaviAppVariationEnabled", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kNaviNTPVariationEnabled = {
"NaviNTPVariationEnabled", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kNaviShortcutVariationEnabled = {
"NaviShortcutVariationEnabled", base::FEATURE_DISABLED_BY_DEFAULT};
#endif // defined(GOOGLE_CHROME_BUILD) && defined(OS_WIN)
// This feature flag is used to force the feature to be turned on for non-win
// and non-branded builds, like with tests or development on other platforms.
const base::Feature kNuxOnboardingForceEnabled = {
......@@ -175,6 +189,17 @@ bool IsNuxOnboardingEnabled(Profile* profile) {
ChromeMetricsServiceAccessor::RegisterSyntheticFieldTrial(
"NaviOnboardingSynthetic", onboard_group);
// Check for feature based on onboarding group.
// TODO(hcarmona): find a solution that scales better.
if (onboard_group.compare("ControlSynthetic-008") == 0)
base::FeatureList::IsEnabled(kNaviControlEnabled);
else if (onboard_group.compare("AppVariationSynthetic-008") == 0)
base::FeatureList::IsEnabled(kNaviAppVariationEnabled);
else if (onboard_group.compare("NTPVariationSynthetic-008") == 0)
base::FeatureList::IsEnabled(kNaviNTPVariationEnabled);
else if (onboard_group.compare("ShortcutVariationSynthetic-008") == 0)
base::FeatureList::IsEnabled(kNaviShortcutVariationEnabled);
if (base::FeatureList::IsEnabled(nux::kNuxOnboardingFeature)) {
return true;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment