Commit 0ab900d2 authored by divya.bansal's avatar divya.bansal Committed by Commit bot

On tapping the disabled option in context menu should not close the menu

In the context menu, disabled items are not required so can be removed
instead of disabling them, so user donot tap on it.

BUG=395551

Review URL: https://codereview.chromium.org/494093003

Cr-Commit-Position: refs/heads/master@{#291861}
parent ececc5a2
...@@ -102,6 +102,7 @@ Derek Halman <d.halman@gmail.com> ...@@ -102,6 +102,7 @@ Derek Halman <d.halman@gmail.com>
Devlin Cronin <rdevlin.cronin@gmail.com> Devlin Cronin <rdevlin.cronin@gmail.com>
Diego Ferreiro Val <elfogris@gmail.com> Diego Ferreiro Val <elfogris@gmail.com>
Dillon Sellars <dill.sellars@gmail.com> Dillon Sellars <dill.sellars@gmail.com>
Divya Bansal <divya.bansal@samsung.com>
Dominic Jodoin <dominic.jodoin@gmail.com> Dominic Jodoin <dominic.jodoin@gmail.com>
Dominik Röttsches <dominik.rottsches@intel.com> Dominik Röttsches <dominik.rottsches@intel.com>
Don Woodward <woodward@adobe.com> Don Woodward <woodward@adobe.com>
......
...@@ -58,14 +58,14 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator { ...@@ -58,14 +58,14 @@ public class ChromeContextMenuPopulator implements ContextMenuPopulator {
menu.findItem(R.id.contextmenu_copy_link_text).setVisible(false); menu.findItem(R.id.contextmenu_copy_link_text).setVisible(false);
} }
menu.findItem(R.id.contextmenu_save_link_as).setEnabled( menu.findItem(R.id.contextmenu_save_link_as).setVisible(
UrlUtilities.isDownloadableScheme(params.getLinkUrl())); UrlUtilities.isDownloadableScheme(params.getLinkUrl()));
if (params.isVideo()) { if (params.isVideo()) {
menu.findItem(R.id.contextmenu_save_video).setEnabled( menu.findItem(R.id.contextmenu_save_video).setVisible(
UrlUtilities.isDownloadableScheme(params.getSrcUrl())); UrlUtilities.isDownloadableScheme(params.getSrcUrl()));
} else if (params.isImage()) { } else if (params.isImage()) {
menu.findItem(R.id.contextmenu_save_image).setEnabled( menu.findItem(R.id.contextmenu_save_image).setVisible(
UrlUtilities.isDownloadableScheme(params.getSrcUrl())); UrlUtilities.isDownloadableScheme(params.getSrcUrl()));
if (mDelegate.canLoadOriginalImage()) { if (mDelegate.canLoadOriginalImage()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment