Commit 0abce31c authored by Reid Kleckner's avatar Reid Kleckner Committed by Commit Bot

Disable OOM reporter test when ASan is present

ASan generally reports OOM by printing an ASan error report to stderr
and exiting with exit code 1. That interferes with base's termination
status classification, and therefore OOM detection. Disable the test for
now.

TBR=csharrison@chromium.org

Change-Id: Ie88b2975cc2fb2fc531462f4cbf98c740b556db2
Reviewed-on: https://chromium-review.googlesource.com/762189Reviewed-by: default avatarReid Kleckner <rnk@chromium.org>
Reviewed-by: default avatarCharlie Harrison <csharrison@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515361}
parent ab2050f1
...@@ -51,8 +51,9 @@ class OutOfMemoryReporterBrowserTest : public InProcessBrowserTest, ...@@ -51,8 +51,9 @@ class OutOfMemoryReporterBrowserTest : public InProcessBrowserTest,
DISALLOW_COPY_AND_ASSIGN(OutOfMemoryReporterBrowserTest); DISALLOW_COPY_AND_ASSIGN(OutOfMemoryReporterBrowserTest);
}; };
// No current reliable way to determine OOM on Linux/Mac. // No current reliable way to determine OOM on Linux/Mac. Sanitizers also
#if defined(OS_LINUX) || defined(OS_MACOSX) // interfere with the exit code on OOM, making this detection unreliable.
#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(ADDRESS_SANITIZER)
#define MAYBE_MemoryExhaust DISABLED_MemoryExhaust #define MAYBE_MemoryExhaust DISABLED_MemoryExhaust
#else #else
#define MAYBE_MemoryExhaust MemoryExhaust #define MAYBE_MemoryExhaust MemoryExhaust
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment