ozone: Remove rvalue references except in move ctor/assignment

These are not supposed to be widely used per the style guide, and aren't
necessary where we're using them. Also const&& makes no sense.

Bug: none
Test: compile
Change-Id: Id16a193d6dfbeee109a1bd6ade61800afbe07574
Reviewed-on: https://chromium-review.googlesource.com/1118976
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572245}

ui/ozone/platform/drm/gpu/drm_thread.cc

@@ -186,7 +186,7 @@ void DrmThread::CreateBufferFromFds(
     gfx::AcceleratedWidget widget,
     const gfx::Size& size,
     gfx::BufferFormat format,
-    std::vector<base::ScopedFD>&& fds,
+    std::vector<base::ScopedFD> fds,
     const std::vector<gfx::NativePixmapPlane>& planes,
     scoped_refptr<GbmBuffer>* buffer) {
   scoped_refptr<GbmDevice> gbm =

ui/ozone/platform/drm/gpu/drm_thread.h

@@ -75,7 +75,7 @@ class DrmThread : public base::Thread,
   void CreateBufferFromFds(gfx::AcceleratedWidget widget,
                            const gfx::Size& size,
                            gfx::BufferFormat format,
-                           std::vector<base::ScopedFD>&& fds,
+                           std::vector<base::ScopedFD> fds,
                            const std::vector<gfx::NativePixmapPlane>& planes,
                            scoped_refptr<GbmBuffer>* buffer);
   void GetScanoutFormats(gfx::AcceleratedWidget widget,

ui/ozone/platform/drm/gpu/drm_thread_proxy.cc

@@ -53,7 +53,7 @@ scoped_refptr<GbmBuffer> DrmThreadProxy::CreateBufferFromFds(
     gfx::AcceleratedWidget widget,
     const gfx::Size& size,
     gfx::BufferFormat format,
-    std::vector<base::ScopedFD>&& fds,
+    std::vector<base::ScopedFD> fds,
     const std::vector<gfx::NativePixmapPlane>& planes) {
   scoped_refptr<GbmBuffer> buffer;
   PostSyncTask(

ui/ozone/platform/drm/gpu/drm_thread_proxy.h

@@ -42,7 +42,7 @@ class DrmThreadProxy {
       gfx::AcceleratedWidget widget,
       const gfx::Size& size,
       gfx::BufferFormat format,
-      std::vector<base::ScopedFD>&& fds,
+      std::vector<base::ScopedFD> fds,
       const std::vector<gfx::NativePixmapPlane>& planes);
 
   void GetScanoutFormats(gfx::AcceleratedWidget widget,

ui/ozone/platform/drm/gpu/gbm_buffer.cc

@@ -36,10 +36,9 @@ GbmBuffer::GbmBuffer(const scoped_refptr<GbmDevice>& gbm,
                      uint32_t format,
                      uint32_t flags,
                      uint64_t modifier,
-                     std::vector<base::ScopedFD>&& fds,
+                     std::vector<base::ScopedFD> fds,
                      const gfx::Size& size,
-
-                     const std::vector<gfx::NativePixmapPlane>&& planes)
+                     std::vector<gfx::NativePixmapPlane> planes)
     : drm_(gbm),
       bo_(bo),
       format_modifier_(modifier),
@@ -254,7 +253,7 @@ scoped_refptr<GbmBuffer> GbmBuffer::CreateBufferFromFds(
     const scoped_refptr<GbmDevice>& gbm,
     uint32_t format,
     const gfx::Size& size,
-    std::vector<base::ScopedFD>&& fds,
+    std::vector<base::ScopedFD> fds,
     const std::vector<gfx::NativePixmapPlane>& planes) {
   TRACE_EVENT2("drm", "GbmBuffer::CreateBufferFromFD", "device",
                gbm->device_path().value(), "size", size.ToString());

ui/ozone/platform/drm/gpu/gbm_buffer.h

@@ -40,7 +40,7 @@ class GbmBuffer : public ScanoutBuffer {
       const scoped_refptr<GbmDevice>& gbm,
       uint32_t format,
       const gfx::Size& size,
-      std::vector<base::ScopedFD>&& fds,
+      std::vector<base::ScopedFD> fds,
       const std::vector<gfx::NativePixmapPlane>& planes);
   uint32_t GetFormat() const { return format_; }
   uint32_t GetFlags() const { return flags_; }
@@ -71,9 +71,9 @@ class GbmBuffer : public ScanoutBuffer {
             uint32_t format,
             uint32_t flags,
             uint64_t modifier,
-            std::vector<base::ScopedFD>&& fds,
+            std::vector<base::ScopedFD> fds,
             const gfx::Size& size,
-            const std::vector<gfx::NativePixmapPlane>&& planes);
+            std::vector<gfx::NativePixmapPlane> planes);
   ~GbmBuffer() override;
 
   static scoped_refptr<GbmBuffer> CreateBufferForBO(