Commit 0ad28b25 authored by Marijn Kruisselbrink's avatar Marijn Kruisselbrink Committed by Commit Bot

[NativeFS] Turn off deprecated API surface.

We plan to ship with this disabled in M86, so turn
all the old API surface off sooner rather than later to give
people using the origin trial more time to adapt.

Bug: 853326
Change-Id: Iacc74d13715bad6d5baaba1e24fd353e002aec16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246904Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788406}
parent 812a4946
...@@ -570,7 +570,6 @@ void SetCustomizedRuntimeFeaturesFromCombinedArgs( ...@@ -570,7 +570,6 @@ void SetCustomizedRuntimeFeaturesFromCombinedArgs(
blink::features::kNativeFileSystemAPI.name, blink::features::kNativeFileSystemAPI.name,
base::FeatureList::OVERRIDE_ENABLE_FEATURE)) { base::FeatureList::OVERRIDE_ENABLE_FEATURE)) {
WebRuntimeFeatures::EnableFeatureFromString("NativeFileSystem", true); WebRuntimeFeatures::EnableFeatureFromString("NativeFileSystem", true);
WebRuntimeFeatures::EnableFeatureFromString("LegacyNativeFileSystem", true);
} }
if (base::FeatureList::IsEnabled(blink::features::kNativeFileSystemAPI) && if (base::FeatureList::IsEnabled(blink::features::kNativeFileSystemAPI) &&
base::FeatureList::IsEnabled(blink::features::kFileHandlingAPI)) { base::FeatureList::IsEnabled(blink::features::kFileHandlingAPI)) {
......
...@@ -1013,9 +1013,6 @@ ...@@ -1013,9 +1013,6 @@
// Used for API surface that will be removed when the Native File System // Used for API surface that will be removed when the Native File System
// API is no longer guarded by an origin trial. // API is no longer guarded by an origin trial.
name: "LegacyNativeFileSystem", name: "LegacyNativeFileSystem",
status: {"Android": "test", "default": "experimental"},
origin_trial_feature_name: "NativeFileSystem2",
origin_trial_os: ["win", "macosx", "linux", "chromeos"],
}, },
{ {
name: "LegacyWindowsDWriteFontFallback", name: "LegacyWindowsDWriteFontFallback",
......
...@@ -11,12 +11,11 @@ generate_token.py http://127.0.0.1:8000 NativeFileSystem2 --expire-timestamp=200 ...@@ -11,12 +11,11 @@ generate_token.py http://127.0.0.1:8000 NativeFileSystem2 --expire-timestamp=200
<script> <script>
test(t => { test(t => {
OriginTrialsHelper.check_properties_exist(this, { OriginTrialsHelper.check_properties_exist(this, {
'FileSystemHandle': ['isFile', 'isDirectory', 'name', 'queryPermission', 'requestPermission'], 'FileSystemHandle': ['kind', 'name', 'queryPermission', 'requestPermission'],
'FileSystemFileHandle': ['getFile', 'createWritable'], 'FileSystemFileHandle': ['getFile', 'createWritable'],
'FileSystemDirectoryHandle': ['getFile', 'getDirectory', 'getEntries', 'removeEntry'], 'FileSystemDirectoryHandle': ['getFileHandle', 'getDirectoryHandle', 'getEntries', 'removeEntry'],
'FileSystemWritableFileStream': ['write', 'truncate', 'close', 'seek'], 'FileSystemWritableFileStream': ['write', 'truncate', 'close', 'seek'],
'global': ['chooseFileSystemEntries'], 'global': ['showOpenFilePicker', 'showSaveFilePicker', 'showDirectoryPicker', 'getOriginPrivateDirectory'],
}); });
assert_true('getSystemDirectory' in self.FileSystemDirectoryHandle);
}, 'Native File System API interfaces and properties in Origin-Trial enabled document.'); }, 'Native File System API interfaces and properties in Origin-Trial enabled document.');
</script> </script>
...@@ -558,13 +558,10 @@ interface FileReader : EventTarget ...@@ -558,13 +558,10 @@ interface FileReader : EventTarget
setter onloadstart setter onloadstart
setter onprogress setter onprogress
interface FileSystemDirectoryHandle : FileSystemHandle interface FileSystemDirectoryHandle : FileSystemHandle
static method getSystemDirectory
attribute @@toStringTag attribute @@toStringTag
method constructor method constructor
method getDirectory
method getDirectoryHandle method getDirectoryHandle
method getEntries method getEntries
method getFile
method getFileHandle method getFileHandle
method removeEntry method removeEntry
method resolve method resolve
...@@ -575,8 +572,6 @@ interface FileSystemFileHandle : FileSystemHandle ...@@ -575,8 +572,6 @@ interface FileSystemFileHandle : FileSystemHandle
method getFile method getFile
interface FileSystemHandle interface FileSystemHandle
attribute @@toStringTag attribute @@toStringTag
getter isDirectory
getter isFile
getter kind getter kind
getter name getter name
method constructor method constructor
......
...@@ -493,13 +493,10 @@ Starting worker: resources/global-interface-listing-worker.js ...@@ -493,13 +493,10 @@ Starting worker: resources/global-interface-listing-worker.js
[Worker] method readAsDataURL [Worker] method readAsDataURL
[Worker] method readAsText [Worker] method readAsText
[Worker] interface FileSystemDirectoryHandle : FileSystemHandle [Worker] interface FileSystemDirectoryHandle : FileSystemHandle
[Worker] static method getSystemDirectory
[Worker] attribute @@toStringTag [Worker] attribute @@toStringTag
[Worker] method constructor [Worker] method constructor
[Worker] method getDirectory
[Worker] method getDirectoryHandle [Worker] method getDirectoryHandle
[Worker] method getEntries [Worker] method getEntries
[Worker] method getFile
[Worker] method getFileHandle [Worker] method getFileHandle
[Worker] method removeEntry [Worker] method removeEntry
[Worker] method resolve [Worker] method resolve
...@@ -510,8 +507,6 @@ Starting worker: resources/global-interface-listing-worker.js ...@@ -510,8 +507,6 @@ Starting worker: resources/global-interface-listing-worker.js
[Worker] method getFile [Worker] method getFile
[Worker] interface FileSystemHandle [Worker] interface FileSystemHandle
[Worker] attribute @@toStringTag [Worker] attribute @@toStringTag
[Worker] getter isDirectory
[Worker] getter isFile
[Worker] getter kind [Worker] getter kind
[Worker] getter name [Worker] getter name
[Worker] method constructor [Worker] method constructor
......
...@@ -2439,13 +2439,10 @@ interface FileReader : EventTarget ...@@ -2439,13 +2439,10 @@ interface FileReader : EventTarget
setter onloadstart setter onloadstart
setter onprogress setter onprogress
interface FileSystemDirectoryHandle : FileSystemHandle interface FileSystemDirectoryHandle : FileSystemHandle
static method getSystemDirectory
attribute @@toStringTag attribute @@toStringTag
method constructor method constructor
method getDirectory
method getDirectoryHandle method getDirectoryHandle
method getEntries method getEntries
method getFile
method getFileHandle method getFileHandle
method removeEntry method removeEntry
method resolve method resolve
...@@ -2456,8 +2453,6 @@ interface FileSystemFileHandle : FileSystemHandle ...@@ -2456,8 +2453,6 @@ interface FileSystemFileHandle : FileSystemHandle
method getFile method getFile
interface FileSystemHandle interface FileSystemHandle
attribute @@toStringTag attribute @@toStringTag
getter isDirectory
getter isFile
getter kind getter kind
getter name getter name
method constructor method constructor
...@@ -11921,7 +11916,6 @@ interface webkitURL ...@@ -11921,7 +11916,6 @@ interface webkitURL
method cancelAnimationFrame method cancelAnimationFrame
method cancelIdleCallback method cancelIdleCallback
method captureEvents method captureEvents
method chooseFileSystemEntries
method clearInterval method clearInterval
method clearTimeout method clearTimeout
method close method close
......
...@@ -488,13 +488,10 @@ Starting worker: resources/global-interface-listing-worker.js ...@@ -488,13 +488,10 @@ Starting worker: resources/global-interface-listing-worker.js
[Worker] method readAsDataURL [Worker] method readAsDataURL
[Worker] method readAsText [Worker] method readAsText
[Worker] interface FileSystemDirectoryHandle : FileSystemHandle [Worker] interface FileSystemDirectoryHandle : FileSystemHandle
[Worker] static method getSystemDirectory
[Worker] attribute @@toStringTag [Worker] attribute @@toStringTag
[Worker] method constructor [Worker] method constructor
[Worker] method getDirectory
[Worker] method getDirectoryHandle [Worker] method getDirectoryHandle
[Worker] method getEntries [Worker] method getEntries
[Worker] method getFile
[Worker] method getFileHandle [Worker] method getFileHandle
[Worker] method removeEntry [Worker] method removeEntry
[Worker] method resolve [Worker] method resolve
...@@ -505,8 +502,6 @@ Starting worker: resources/global-interface-listing-worker.js ...@@ -505,8 +502,6 @@ Starting worker: resources/global-interface-listing-worker.js
[Worker] method getFile [Worker] method getFile
[Worker] interface FileSystemHandle [Worker] interface FileSystemHandle
[Worker] attribute @@toStringTag [Worker] attribute @@toStringTag
[Worker] getter isDirectory
[Worker] getter isFile
[Worker] getter kind [Worker] getter kind
[Worker] getter name [Worker] getter name
[Worker] method constructor [Worker] method constructor
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment