Commit 0af66703 authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

Remove cors:: namespace specifier in the namespace

Bug: None
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib487fee40beaac941b74c090d31133b12d61ea4a
Reviewed-on: https://chromium-review.googlesource.com/1203517
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: default avatarTakashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589158}
parent f34633d9
...@@ -27,7 +27,7 @@ base::Optional<std::string> GetHeaderString( ...@@ -27,7 +27,7 @@ base::Optional<std::string> GetHeaderString(
} }
bool NeedsPreflight(const ResourceRequest& request) { bool NeedsPreflight(const ResourceRequest& request) {
if (!cors::IsCORSEnabledRequestMode(request.fetch_request_mode)) if (!IsCORSEnabledRequestMode(request.fetch_request_mode))
return false; return false;
if (request.is_external_request) if (request.is_external_request)
...@@ -88,7 +88,7 @@ CORSURLLoader::~CORSURLLoader() = default; ...@@ -88,7 +88,7 @@ CORSURLLoader::~CORSURLLoader() = default;
void CORSURLLoader::Start() { void CORSURLLoader::Start() {
if (fetch_cors_flag_ && if (fetch_cors_flag_ &&
cors::IsCORSEnabledRequestMode(request_.fetch_request_mode)) { IsCORSEnabledRequestMode(request_.fetch_request_mode)) {
// Username and password should be stripped in a CORS-enabled request. // Username and password should be stripped in a CORS-enabled request.
if (request_.url.has_username() || request_.url.has_password()) { if (request_.url.has_username() || request_.url.has_password()) {
GURL::Replacements replacements; GURL::Replacements replacements;
......
...@@ -81,18 +81,18 @@ std::unique_ptr<ResourceRequest> CreatePreflightRequest( ...@@ -81,18 +81,18 @@ std::unique_ptr<ResourceRequest> CreatePreflightRequest(
preflight_request->load_flags |= net::LOAD_DO_NOT_SEND_AUTH_DATA; preflight_request->load_flags |= net::LOAD_DO_NOT_SEND_AUTH_DATA;
preflight_request->headers.SetHeader( preflight_request->headers.SetHeader(
cors::header_names::kAccessControlRequestMethod, request.method); header_names::kAccessControlRequestMethod, request.method);
std::string request_headers = std::string request_headers =
CreateAccessControlRequestHeadersHeader(request.headers); CreateAccessControlRequestHeadersHeader(request.headers);
if (!request_headers.empty()) { if (!request_headers.empty()) {
preflight_request->headers.SetHeader( preflight_request->headers.SetHeader(
cors::header_names::kAccessControlRequestHeaders, request_headers); header_names::kAccessControlRequestHeaders, request_headers);
} }
if (request.is_external_request) { if (request.is_external_request) {
preflight_request->headers.SetHeader( preflight_request->headers.SetHeader(
cors::header_names::kAccessControlRequestExternal, "true"); header_names::kAccessControlRequestExternal, "true");
} }
DCHECK(request.request_initiator); DCHECK(request.request_initiator);
...@@ -123,10 +123,9 @@ std::unique_ptr<PreflightResult> CreatePreflightResult( ...@@ -123,10 +123,9 @@ std::unique_ptr<PreflightResult> CreatePreflightResult(
// TODO(toyoshim): Reflect --allow-file-access-from-files flag. // TODO(toyoshim): Reflect --allow-file-access-from-files flag.
*detected_error_status = CheckPreflightAccess( *detected_error_status = CheckPreflightAccess(
final_url, head.headers->response_code(), final_url, head.headers->response_code(),
GetHeaderString(head.headers, header_names::kAccessControlAllowOrigin),
GetHeaderString(head.headers, GetHeaderString(head.headers,
cors::header_names::kAccessControlAllowOrigin), header_names::kAccessControlAllowCredentials),
GetHeaderString(head.headers,
cors::header_names::kAccessControlAllowCredentials),
original_request.fetch_credentials_mode, original_request.fetch_credentials_mode,
tainted ? url::Origin() : *original_request.request_initiator, tainted ? url::Origin() : *original_request.request_initiator,
false /* allow_file_origin */); false /* allow_file_origin */);
......
...@@ -50,7 +50,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, LexicographicalOrder) { ...@@ -50,7 +50,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, LexicographicalOrder) {
EXPECT_EQ("null", header); EXPECT_EQ("null", header);
EXPECT_TRUE(preflight->headers.GetHeader( EXPECT_TRUE(preflight->headers.GetHeader(
cors::header_names::kAccessControlRequestHeaders, &header)); header_names::kAccessControlRequestHeaders, &header));
EXPECT_EQ("apple,content-type,kiwifruit,orange,strawberry", header); EXPECT_EQ("apple,content-type,kiwifruit,orange,strawberry", header);
} }
...@@ -73,7 +73,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, ExcludeSimpleHeaders) { ...@@ -73,7 +73,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, ExcludeSimpleHeaders) {
// left out in the preflight request. // left out in the preflight request.
std::string header; std::string header;
EXPECT_FALSE(preflight->headers.GetHeader( EXPECT_FALSE(preflight->headers.GetHeader(
cors::header_names::kAccessControlRequestHeaders, &header)); header_names::kAccessControlRequestHeaders, &header));
} }
TEST(PreflightControllerCreatePreflightRequestTest, Credentials) { TEST(PreflightControllerCreatePreflightRequestTest, Credentials) {
...@@ -108,7 +108,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, ...@@ -108,7 +108,7 @@ TEST(PreflightControllerCreatePreflightRequestTest,
// Empty list also; see comment in test above. // Empty list also; see comment in test above.
std::string header; std::string header;
EXPECT_FALSE(preflight->headers.GetHeader( EXPECT_FALSE(preflight->headers.GetHeader(
cors::header_names::kAccessControlRequestHeaders, &header)); header_names::kAccessControlRequestHeaders, &header));
} }
TEST(PreflightControllerCreatePreflightRequestTest, IncludeNonSimpleHeader) { TEST(PreflightControllerCreatePreflightRequestTest, IncludeNonSimpleHeader) {
...@@ -123,7 +123,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, IncludeNonSimpleHeader) { ...@@ -123,7 +123,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, IncludeNonSimpleHeader) {
std::string header; std::string header;
EXPECT_TRUE(preflight->headers.GetHeader( EXPECT_TRUE(preflight->headers.GetHeader(
cors::header_names::kAccessControlRequestHeaders, &header)); header_names::kAccessControlRequestHeaders, &header));
EXPECT_EQ("x-custom-header", header); EXPECT_EQ("x-custom-header", header);
} }
...@@ -141,7 +141,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, ...@@ -141,7 +141,7 @@ TEST(PreflightControllerCreatePreflightRequestTest,
std::string header; std::string header;
EXPECT_TRUE(preflight->headers.GetHeader( EXPECT_TRUE(preflight->headers.GetHeader(
cors::header_names::kAccessControlRequestHeaders, &header)); header_names::kAccessControlRequestHeaders, &header));
EXPECT_EQ("content-type", header); EXPECT_EQ("content-type", header);
} }
...@@ -157,7 +157,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, ExcludeForbiddenHeaders) { ...@@ -157,7 +157,7 @@ TEST(PreflightControllerCreatePreflightRequestTest, ExcludeForbiddenHeaders) {
std::string header; std::string header;
EXPECT_FALSE(preflight->headers.GetHeader( EXPECT_FALSE(preflight->headers.GetHeader(
cors::header_names::kAccessControlRequestHeaders, &header)); header_names::kAccessControlRequestHeaders, &header));
} }
TEST(PreflightControllerCreatePreflightRequestTest, Tainted) { TEST(PreflightControllerCreatePreflightRequestTest, Tainted) {
...@@ -256,7 +256,7 @@ class PreflightControllerTest : public testing::Test { ...@@ -256,7 +256,7 @@ class PreflightControllerTest : public testing::Test {
net::test_server::ShouldHandle(request, "/tainted") net::test_server::ShouldHandle(request, "/tainted")
? url::Origin() ? url::Origin()
: url::Origin::Create(test_server_.base_url()); : url::Origin::Create(test_server_.base_url());
response->AddCustomHeader(cors::header_names::kAccessControlAllowOrigin, response->AddCustomHeader(header_names::kAccessControlAllowOrigin,
origin.Serialize()); origin.Serialize());
response->AddCustomHeader(header_names::kAccessControlAllowMethods, response->AddCustomHeader(header_names::kAccessControlAllowMethods,
"GET, OPTIONS"); "GET, OPTIONS");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment