Commit 0af9f482 authored by chrishenry's avatar chrishenry Committed by Commit bot

Rename AddPage -> AddUserStory in tools/telemetry.

BUG=439512

Review URL: https://codereview.chromium.org/805613002

Cr-Commit-Position: refs/heads/master@{#308276}
parent 61e3f056
......@@ -91,7 +91,7 @@ class Page(user_story.UserStory):
return
self._page_set.pages.remove(self)
self._page_set = another_page_set
self._page_set.AddPage(self)
self._page_set.AddUserStory(self)
def RunNavigateSteps(self, action_runner):
action_runner.NavigateToPage(self)
......
......@@ -80,7 +80,7 @@ class PageSet(user_story_set.UserStorySet):
for csv_row in csv_reader:
if csv_row[url_index] in page_set_dict:
self.AddPage(page_set_dict[csv_row[url_index]])
self.AddUserStory(page_set_dict[csv_row[url_index]])
else:
raise Exception('Unusable results_file.')
......
......@@ -49,13 +49,13 @@ class TestPageSet(unittest.TestCase):
page.Page('http://bar.com', page_set_a),
]
for p in pages:
page_set_a.AddPage(p)
page_set_a.AddUserStory(p)
# Form page_set_b from sub page_set_a.
page_set_b = page_set.PageSet()
for p in pages:
p.TransferToPageSet(page_set_b)
page_set_b.AddPage(page.Page('http://baz.com', page_set_b))
page_set_b.AddUserStory(page.Page('http://baz.com', page_set_b))
self.assertEqual(0, len(page_set_a.pages))
self.assertEqual(
set(['http://foo.com', 'http://bar.com', 'http://baz.com']),
......
......@@ -144,7 +144,7 @@ class PageTestUnitTest(page_test_test_case.PageTestTestCase):
def testRunActions(self):
ps = self.CreateEmptyPageSet()
page = PageWithAction('file://blank.html', ps)
ps.AddPage(page)
ps.AddUserStory(page)
measurement = PageTestWithAction()
self.RunMeasurement(measurement, ps, options=self._options)
self.assertTrue(page.run_test_action_called)
......@@ -151,9 +151,9 @@ class TestPage(unittest.TestCase):
page_bar = page.Page('http://bar.com', page_set_a)
page_baz = page.Page('http://baz.com', page_set_a)
page_set_a.AddPage(page_foo)
page_set_a.AddPage(page_bar)
page_set_a.AddPage(page_baz)
page_set_a.AddUserStory(page_foo)
page_set_a.AddUserStory(page_bar)
page_set_a.AddUserStory(page_baz)
page_bar.TransferToPageSet(page_set_b)
self.assertEqual([page_foo, page_baz], page_set_a.pages)
......
......@@ -36,7 +36,7 @@ class MockPage(page_module.Page):
class MockPageSet(page_set_module.PageSet):
def __init__(self, url=''):
super(MockPageSet, self).__init__(archive_data_file='data/test.json')
self.AddPage(MockPage(self, url))
self.AddUserStory(MockPage(self, url))
class MockPageTest(page_test.PageTest):
......
......@@ -40,7 +40,7 @@ class PageTestTestCase(unittest.TestCase):
def CreatePageSetFromFileInUnittestDataDir(self, test_filename):
ps = self.CreateEmptyPageSet()
page = BasicTestPage('file://' + test_filename, ps, base_dir=ps.base_dir)
ps.AddPage(page)
ps.AddUserStory(page)
return ps
def CreateEmptyPageSet(self):
......
......@@ -212,7 +212,7 @@ class TimelineBasedMeasurementTest(page_test_test_case.PageTestTestCase):
@benchmark.Disabled('android', 'mac')
def testSmoothnessTimelineBasedMeasurementForSmoke(self):
ps = self.CreateEmptyPageSet()
ps.AddPage(TestTimelinebasedMeasurementPage(
ps.AddUserStory(TestTimelinebasedMeasurementPage(
ps, ps.base_dir, trigger_animation=True))
measurement = tbm_module.TimelineBasedMeasurement()
......@@ -232,7 +232,7 @@ class TimelineBasedMeasurementTest(page_test_test_case.PageTestTestCase):
@benchmark.Disabled('android', 'mac')
def testFastTimelineBasedMeasurementForSmoke(self):
ps = self.CreateEmptyPageSet()
ps.AddPage(TestTimelinebasedMeasurementPage(
ps.AddUserStory(TestTimelinebasedMeasurementPage(
ps, ps.base_dir, trigger_slow=True))
measurement = tbm_module.TimelineBasedMeasurement()
......@@ -270,7 +270,7 @@ class TimelineBasedMeasurementTest(page_test_test_case.PageTestTestCase):
@benchmark.Disabled('android', 'win', 'mac')
def testMainthreadJankTimelineBasedMeasurement(self):
ps = self.CreateEmptyPageSet()
ps.AddPage(TestTimelinebasedMeasurementPage(
ps.AddUserStory(TestTimelinebasedMeasurementPage(
ps, ps.base_dir, trigger_jank=True))
measurement = tbm_module.TimelineBasedMeasurement()
......
......@@ -30,6 +30,6 @@ class TestPageSet(page_set.PageSet):
def RunGetActionRunner(self, action_runner):
return action_runner
self.AddPage(Google(self))
self.AddPage(InternalPage(self))
self.AddPage(ExternalPage(self))
self.AddUserStory(Google(self))
self.AddUserStory(InternalPage(self))
self.AddUserStory(ExternalPage(self))
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment