Commit 0b168df0 authored by François Doray's avatar François Doray Committed by Commit Bot

Revert "Add DevTools check to CrashKeys for crbug.com/824774."

This reverts commit b1d6f80a.

Reason for revert: https://crbug.com/827392

Original change's description:
> Add DevTools check to CrashKeys for crbug.com/824774.
> 
> Record whether DevTools is currently active in CrashKeys.
> 
> Bug: 824774
> Change-Id: I697bf892037c63216890d9d5f7ccc67e037f3b19
> Reviewed-on: https://chromium-review.googlesource.com/986453
> Commit-Queue: James MacLean <wjmaclean@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546929}

TBR=kenrb@chromium.org,wjmaclean@chromium.org

Change-Id: Id3f8c9b4810facf9cb0b7f15ad6699c691f2042c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 824774, 827392
Reviewed-on: https://chromium-review.googlesource.com/987172Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547003}
parent 4fee6e81
...@@ -1192,22 +1192,11 @@ void RenderWidgetHostInputEventRouter::DispatchTouchscreenGestureEvent( ...@@ -1192,22 +1192,11 @@ void RenderWidgetHostInputEventRouter::DispatchTouchscreenGestureEvent(
event.SetPositionInWidget(event.PositionInWidget() + event.SetPositionInWidget(event.PositionInWidget() +
touchscreen_gesture_target_.delta); touchscreen_gesture_target_.delta);
// Temporary logging for https://crbug.com/824774. // Temporary logging for https://crbug.com/824774.
// TODO(wjmaclean): Remove all this logging code once the issue is resolved.
static auto* target_ptr_key = base::debug::AllocateCrashKeyString( static auto* target_ptr_key = base::debug::AllocateCrashKeyString(
"touchscreen-gesture-target-ptr", base::debug::CrashKeySize::Size64); "touchscreen-gesture-target-ptr", base::debug::CrashKeySize::Size64);
base::debug::SetCrashKeyString( base::debug::SetCrashKeyString(
target_ptr_key, target_ptr_key,
base::StringPrintf("%p", touchscreen_gesture_target_.target)); base::StringPrintf("%p", touchscreen_gesture_target_.target));
// Issue 824772 is a potential cause for issue 824774. Report whether
// devtools is in use to investigate this possibility.
auto* contents = root_view->host()->delegate()->GetAsWebContents();
const bool have_devtools =
contents && DevToolsAgentHost::IsDebuggerAttached(contents);
static auto* devtools_key = base::debug::AllocateCrashKeyString(
"touchscreen-gesture-target-have-devtools",
base::debug::CrashKeySize::Size32);
base::debug::SetCrashKeyString(devtools_key, std::to_string(have_devtools));
// Crash in 824774 appears to happen on next line.
touchscreen_gesture_target_.target->ProcessGestureEvent(event, latency); touchscreen_gesture_target_.target->ProcessGestureEvent(event, latency);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment