Commit 0b3e8bde authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Extensions Menu] Remove child view from proper parent

We were trying to remove a child view from the wrong parent. Fix this.

This makes BrowserActionApiTest.Basic pass with the ExtensionsMenu
enabled.

Bug: 984654
Change-Id: I5e648e487fa173370f17eb841587f6136eb67e20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019926Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735027}
parent b35eaf8f
...@@ -335,7 +335,7 @@ void ExtensionsMenuView::Update() { ...@@ -335,7 +335,7 @@ void ExtensionsMenuView::Update() {
} }
for (ExtensionsMenuItemView* menu_item : views_to_move) { for (ExtensionsMenuItemView* menu_item : views_to_move) {
section->container->RemoveChildView(menu_item); section->menu_items->RemoveChildView(menu_item);
InsertMenuItem(menu_item); InsertMenuItem(menu_item);
} }
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment