Commit 0b6a06e4 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

[ios] Fix uses of ios::ChromeBrowserState in /ios/chrome/browser/ui/webui

The ChromeBrowserState has been moved from the "ios" namespace
to the global namespace by http://crrev.com/c/2014913. Fix the
uses from ios::ChromeBrowserState to ChromeBrowserState.

Also remove includes of chrome_browser_state_forward.h and use
a simple forward declaration instead (since the old name is no
longer necessary).

This CL was uploaded by git cl split.

R=eugenebut@chromium.org

Bug: 1042208
Change-Id: Ic8e0433afeeabe0b65e8aed99c40b3a8ff513abe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017426Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735294}
parent 4ead0fd5
...@@ -153,7 +153,7 @@ bool AboutUIHTMLSource::ShouldDenyXFrameOptions() const { ...@@ -153,7 +153,7 @@ bool AboutUIHTMLSource::ShouldDenyXFrameOptions() const {
AboutUI::AboutUI(web::WebUIIOS* web_ui, const std::string& name) AboutUI::AboutUI(web::WebUIIOS* web_ui, const std::string& name)
: web::WebUIIOSController(web_ui) { : web::WebUIIOSController(web_ui) {
web::URLDataSourceIOS::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), web::URLDataSourceIOS::Add(ChromeBrowserState::FromWebUIIOS(web_ui),
new AboutUIHTMLSource(name)); new AboutUIHTMLSource(name));
} }
......
...@@ -19,8 +19,7 @@ using autofill::LogRouter; ...@@ -19,8 +19,7 @@ using autofill::LogRouter;
AutofillInternalsUIIOS::AutofillInternalsUIIOS(web::WebUIIOS* web_ui) AutofillInternalsUIIOS::AutofillInternalsUIIOS(web::WebUIIOS* web_ui)
: web::WebUIIOSController(web_ui) { : web::WebUIIOSController(web_ui) {
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state = ChromeBrowserState::FromWebUIIOS(web_ui);
ios::ChromeBrowserState::FromWebUIIOS(web_ui);
web::WebUIIOSDataSource::Add( web::WebUIIOSDataSource::Add(
browser_state, browser_state,
autofill::CreateInternalsHTMLSource(kChromeUIAutofillInternalsHost)); autofill::CreateInternalsHTMLSource(kChromeUIAutofillInternalsHost));
......
...@@ -33,7 +33,7 @@ class InternalsUIHandler : public web::WebUIIOSMessageHandler, ...@@ -33,7 +33,7 @@ class InternalsUIHandler : public web::WebUIIOSMessageHandler,
public autofill::LogReceiver { public autofill::LogReceiver {
public: public:
using GetLogRouterFunction = using GetLogRouterFunction =
base::RepeatingCallback<LogRouter*(ios::ChromeBrowserState*)>; base::RepeatingCallback<LogRouter*(ChromeBrowserState*)>;
explicit InternalsUIHandler(std::string call_on_load, explicit InternalsUIHandler(std::string call_on_load,
GetLogRouterFunction get_log_router_function); GetLogRouterFunction get_log_router_function);
......
...@@ -69,8 +69,8 @@ void InternalsUIHandler::RegisterMessages() { ...@@ -69,8 +69,8 @@ void InternalsUIHandler::RegisterMessages() {
void InternalsUIHandler::OnLoaded(const base::ListValue* args) { void InternalsUIHandler::OnLoaded(const base::ListValue* args) {
web_ui()->CallJavascriptFunction(call_on_load_, {}); web_ui()->CallJavascriptFunction(call_on_load_, {});
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state =
ios::ChromeBrowserState::FromWebUIIOS(web_ui()); ChromeBrowserState::FromWebUIIOS(web_ui());
base::Value is_incognito(browser_state->IsOffTheRecord()); base::Value is_incognito(browser_state->IsOffTheRecord());
web_ui()->CallJavascriptFunction("notifyAboutIncognito", {&is_incognito}); web_ui()->CallJavascriptFunction("notifyAboutIncognito", {&is_incognito});
web_ui()->CallJavascriptFunction("notifyAboutVariations", web_ui()->CallJavascriptFunction("notifyAboutVariations",
...@@ -79,8 +79,8 @@ void InternalsUIHandler::OnLoaded(const base::ListValue* args) { ...@@ -79,8 +79,8 @@ void InternalsUIHandler::OnLoaded(const base::ListValue* args) {
} }
void InternalsUIHandler::StartSubscription() { void InternalsUIHandler::StartSubscription() {
LogRouter* log_router = get_log_router_function_.Run( LogRouter* log_router =
ios::ChromeBrowserState::FromWebUIIOS(web_ui())); get_log_router_function_.Run(ChromeBrowserState::FromWebUIIOS(web_ui()));
if (!log_router) if (!log_router)
return; return;
...@@ -95,8 +95,8 @@ void InternalsUIHandler::EndSubscription() { ...@@ -95,8 +95,8 @@ void InternalsUIHandler::EndSubscription() {
if (!registered_with_log_router_) if (!registered_with_log_router_)
return; return;
registered_with_log_router_ = false; registered_with_log_router_ = false;
LogRouter* log_router = get_log_router_function_.Run( LogRouter* log_router =
ios::ChromeBrowserState::FromWebUIIOS(web_ui())); get_log_router_function_.Run(ChromeBrowserState::FromWebUIIOS(web_ui()));
if (log_router) if (log_router)
log_router->UnregisterReceiver(this); log_router->UnregisterReceiver(this);
} }
......
...@@ -20,8 +20,7 @@ using autofill::LogRouter; ...@@ -20,8 +20,7 @@ using autofill::LogRouter;
PasswordManagerInternalsUIIOS::PasswordManagerInternalsUIIOS( PasswordManagerInternalsUIIOS::PasswordManagerInternalsUIIOS(
web::WebUIIOS* web_ui) web::WebUIIOS* web_ui)
: web::WebUIIOSController(web_ui) { : web::WebUIIOSController(web_ui) {
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state = ChromeBrowserState::FromWebUIIOS(web_ui);
ios::ChromeBrowserState::FromWebUIIOS(web_ui);
web::WebUIIOSDataSource::Add(browser_state, web::WebUIIOSDataSource::Add(browser_state,
autofill::CreateInternalsHTMLSource( autofill::CreateInternalsHTMLSource(
kChromeUIPasswordManagerInternalsHost)); kChromeUIPasswordManagerInternalsHost));
......
...@@ -156,6 +156,6 @@ CrashesUI::CrashesUI(web::WebUIIOS* web_ui) : web::WebUIIOSController(web_ui) { ...@@ -156,6 +156,6 @@ CrashesUI::CrashesUI(web::WebUIIOS* web_ui) : web::WebUIIOSController(web_ui) {
web_ui->AddMessageHandler(std::make_unique<CrashesDOMHandler>()); web_ui->AddMessageHandler(std::make_unique<CrashesDOMHandler>());
// Set up the chrome://crashes/ source. // Set up the chrome://crashes/ source.
web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), web::WebUIIOSDataSource::Add(ChromeBrowserState::FromWebUIIOS(web_ui),
CreateCrashesUIHTMLSource()); CreateCrashesUIHTMLSource());
} }
...@@ -201,7 +201,7 @@ FlagsUI::FlagsUI(web::WebUIIOS* web_ui) ...@@ -201,7 +201,7 @@ FlagsUI::FlagsUI(web::WebUIIOS* web_ui)
flag_access); flag_access);
// Set up the about:flags source. // Set up the about:flags source.
web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), web::WebUIIOSDataSource::Add(ChromeBrowserState::FromWebUIIOS(web_ui),
CreateFlagsUIHTMLSource()); CreateFlagsUIHTMLSource());
} }
......
...@@ -88,10 +88,10 @@ class InspectDOMHandler : public web::WebUIIOSMessageHandler, ...@@ -88,10 +88,10 @@ class InspectDOMHandler : public web::WebUIIOSMessageHandler,
// TabModelListObserver // TabModelListObserver
void TabModelRegisteredWithBrowserState( void TabModelRegisteredWithBrowserState(
TabModel* tab_model, TabModel* tab_model,
ios::ChromeBrowserState* browser_state) override; ChromeBrowserState* browser_state) override;
void TabModelUnregisteredFromBrowserState( void TabModelUnregisteredFromBrowserState(
TabModel* tab_model, TabModel* tab_model,
ios::ChromeBrowserState* browser_state) override; ChromeBrowserState* browser_state) override;
// WebStateListObserver // WebStateListObserver
void WebStateInsertedAt(WebStateList* web_state_list, void WebStateInsertedAt(WebStateList* web_state_list,
...@@ -152,8 +152,8 @@ void InspectDOMHandler::SetLoggingEnabled(bool enabled) { ...@@ -152,8 +152,8 @@ void InspectDOMHandler::SetLoggingEnabled(bool enabled) {
logging_enabled_ = enabled; logging_enabled_ = enabled;
web::BrowserState* browser_state = web_ui()->GetWebState()->GetBrowserState(); web::BrowserState* browser_state = web_ui()->GetWebState()->GetBrowserState();
ios::ChromeBrowserState* chrome_browser_state = ChromeBrowserState* chrome_browser_state =
ios::ChromeBrowserState::FromBrowserState(browser_state); ChromeBrowserState::FromBrowserState(browser_state);
NSArray<TabModel*>* tab_models = NSArray<TabModel*>* tab_models =
TabModelList::GetTabModelsForChromeBrowserState(chrome_browser_state); TabModelList::GetTabModelsForChromeBrowserState(chrome_browser_state);
...@@ -219,14 +219,14 @@ void InspectDOMHandler::SetDelegateForWebStatesInTabModel( ...@@ -219,14 +219,14 @@ void InspectDOMHandler::SetDelegateForWebStatesInTabModel(
// TabModelListObserver // TabModelListObserver
void InspectDOMHandler::TabModelRegisteredWithBrowserState( void InspectDOMHandler::TabModelRegisteredWithBrowserState(
TabModel* tab_model, TabModel* tab_model,
ios::ChromeBrowserState* browser_state) { ChromeBrowserState* browser_state) {
tab_model.webStateList->AddObserver(this); tab_model.webStateList->AddObserver(this);
SetDelegateForWebStatesInTabModel(tab_model, this); SetDelegateForWebStatesInTabModel(tab_model, this);
} }
void InspectDOMHandler::TabModelUnregisteredFromBrowserState( void InspectDOMHandler::TabModelUnregisteredFromBrowserState(
TabModel* tab_model, TabModel* tab_model,
ios::ChromeBrowserState* browser_state) { ChromeBrowserState* browser_state) {
tab_model.webStateList->RemoveObserver(this); tab_model.webStateList->RemoveObserver(this);
SetDelegateForWebStatesInTabModel(tab_model, nullptr); SetDelegateForWebStatesInTabModel(tab_model, nullptr);
} }
...@@ -260,7 +260,7 @@ InspectUI::InspectUI(web::WebUIIOS* web_ui) : web::WebUIIOSController(web_ui) { ...@@ -260,7 +260,7 @@ InspectUI::InspectUI(web::WebUIIOS* web_ui) : web::WebUIIOSController(web_ui) {
web_ui->AddMessageHandler(std::make_unique<InspectDOMHandler>()); web_ui->AddMessageHandler(std::make_unique<InspectDOMHandler>());
web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), web::WebUIIOSDataSource::Add(ChromeBrowserState::FromWebUIIOS(web_ui),
CreateInspectUIHTMLSource()); CreateInspectUIHTMLSource());
} }
......
...@@ -87,8 +87,7 @@ OmahaUI::OmahaUI(web::WebUIIOS* web_ui) : WebUIIOSController(web_ui) { ...@@ -87,8 +87,7 @@ OmahaUI::OmahaUI(web::WebUIIOS* web_ui) : WebUIIOSController(web_ui) {
web_ui->AddMessageHandler(std::make_unique<OmahaDOMHandler>()); web_ui->AddMessageHandler(std::make_unique<OmahaDOMHandler>());
// Set up the chrome://omaha/ source. // Set up the chrome://omaha/ source.
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state = ChromeBrowserState::FromWebUIIOS(web_ui);
ios::ChromeBrowserState::FromWebUIIOS(web_ui);
web::WebUIIOSDataSource::Add(browser_state, CreateOmahaUIHTMLSource()); web::WebUIIOSDataSource::Add(browser_state, CreateOmahaUIHTMLSource());
} }
......
...@@ -22,7 +22,7 @@ namespace { ...@@ -22,7 +22,7 @@ namespace {
// state. // state.
class PrefsInternalsSource : public web::URLDataSourceIOS { class PrefsInternalsSource : public web::URLDataSourceIOS {
public: public:
explicit PrefsInternalsSource(ios::ChromeBrowserState* browser_state) explicit PrefsInternalsSource(ChromeBrowserState* browser_state)
: browser_state_(browser_state) {} : browser_state_(browser_state) {}
~PrefsInternalsSource() override = default; ~PrefsInternalsSource() override = default;
...@@ -55,7 +55,7 @@ class PrefsInternalsSource : public web::URLDataSourceIOS { ...@@ -55,7 +55,7 @@ class PrefsInternalsSource : public web::URLDataSourceIOS {
} }
private: private:
ios::ChromeBrowserState* browser_state_; ChromeBrowserState* browser_state_;
DISALLOW_COPY_AND_ASSIGN(PrefsInternalsSource); DISALLOW_COPY_AND_ASSIGN(PrefsInternalsSource);
}; };
...@@ -64,8 +64,7 @@ class PrefsInternalsSource : public web::URLDataSourceIOS { ...@@ -64,8 +64,7 @@ class PrefsInternalsSource : public web::URLDataSourceIOS {
PrefsInternalsUI::PrefsInternalsUI(web::WebUIIOS* web_ui) PrefsInternalsUI::PrefsInternalsUI(web::WebUIIOS* web_ui)
: web::WebUIIOSController(web_ui) { : web::WebUIIOSController(web_ui) {
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state = ChromeBrowserState::FromWebUIIOS(web_ui);
ios::ChromeBrowserState::FromWebUIIOS(web_ui);
web::URLDataSourceIOS::Add(browser_state, web::URLDataSourceIOS::Add(browser_state,
new PrefsInternalsSource(browser_state)); new PrefsInternalsSource(browser_state));
} }
......
...@@ -35,8 +35,7 @@ web::WebUIIOSDataSource* CreateSignInInternalsHTMLSource() { ...@@ -35,8 +35,7 @@ web::WebUIIOSDataSource* CreateSignInInternalsHTMLSource() {
SignInInternalsUIIOS::SignInInternalsUIIOS(web::WebUIIOS* web_ui) SignInInternalsUIIOS::SignInInternalsUIIOS(web::WebUIIOS* web_ui)
: WebUIIOSController(web_ui) { : WebUIIOSController(web_ui) {
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state = ChromeBrowserState::FromWebUIIOS(web_ui);
ios::ChromeBrowserState::FromWebUIIOS(web_ui);
DCHECK(browser_state); DCHECK(browser_state);
web::WebUIIOSDataSource::Add(browser_state, web::WebUIIOSDataSource::Add(browser_state,
CreateSignInInternalsHTMLSource()); CreateSignInInternalsHTMLSource());
...@@ -48,8 +47,8 @@ SignInInternalsUIIOS::SignInInternalsUIIOS(web::WebUIIOS* web_ui) ...@@ -48,8 +47,8 @@ SignInInternalsUIIOS::SignInInternalsUIIOS(web::WebUIIOS* web_ui)
} }
SignInInternalsUIIOS::~SignInInternalsUIIOS() { SignInInternalsUIIOS::~SignInInternalsUIIOS() {
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state =
ios::ChromeBrowserState::FromWebUIIOS(web_ui()); ChromeBrowserState::FromWebUIIOS(web_ui());
DCHECK(browser_state); DCHECK(browser_state);
AboutSigninInternals* about_signin_internals = AboutSigninInternals* about_signin_internals =
ios::AboutSigninInternalsFactory::GetForBrowserState(browser_state); ios::AboutSigninInternalsFactory::GetForBrowserState(browser_state);
...@@ -62,8 +61,8 @@ bool SignInInternalsUIIOS::OverrideHandleWebUIIOSMessage( ...@@ -62,8 +61,8 @@ bool SignInInternalsUIIOS::OverrideHandleWebUIIOSMessage(
const std::string& name, const std::string& name,
const base::ListValue& content) { const base::ListValue& content) {
if (name == "getSigninInfo") { if (name == "getSigninInfo") {
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state =
ios::ChromeBrowserState::FromWebUIIOS(web_ui()); ChromeBrowserState::FromWebUIIOS(web_ui());
DCHECK(browser_state); DCHECK(browser_state);
AboutSigninInternals* about_signin_internals = AboutSigninInternals* about_signin_internals =
......
...@@ -62,8 +62,7 @@ std::string SuggestionsSourceWrapper::GetMimeType( ...@@ -62,8 +62,7 @@ std::string SuggestionsSourceWrapper::GetMimeType(
SuggestionsUI::SuggestionsUI(web::WebUIIOS* web_ui) SuggestionsUI::SuggestionsUI(web::WebUIIOS* web_ui)
: web::WebUIIOSController(web_ui) { : web::WebUIIOSController(web_ui) {
ios::ChromeBrowserState* browser_state = ChromeBrowserState* browser_state = ChromeBrowserState::FromWebUIIOS(web_ui);
ios::ChromeBrowserState::FromWebUIIOS(web_ui);
web::URLDataSourceIOS::Add( web::URLDataSourceIOS::Add(
browser_state, browser_state,
new SuggestionsSourceWrapper( new SuggestionsSourceWrapper(
......
...@@ -91,7 +91,7 @@ bool TermsUIHTMLSource::ShouldDenyXFrameOptions() const { ...@@ -91,7 +91,7 @@ bool TermsUIHTMLSource::ShouldDenyXFrameOptions() const {
TermsUI::TermsUI(web::WebUIIOS* web_ui, const std::string& name) TermsUI::TermsUI(web::WebUIIOS* web_ui, const std::string& name)
: web::WebUIIOSController(web_ui) { : web::WebUIIOSController(web_ui) {
web::URLDataSourceIOS::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), web::URLDataSourceIOS::Add(ChromeBrowserState::FromWebUIIOS(web_ui),
new TermsUIHTMLSource(name)); new TermsUIHTMLSource(name));
} }
......
...@@ -52,8 +52,8 @@ void IOSTranslateInternalsHandler::CallJavascriptFunction( ...@@ -52,8 +52,8 @@ void IOSTranslateInternalsHandler::CallJavascriptFunction(
void IOSTranslateInternalsHandler::RegisterMessages() { void IOSTranslateInternalsHandler::RegisterMessages() {
web::BrowserState* browser_state = web_ui()->GetWebState()->GetBrowserState(); web::BrowserState* browser_state = web_ui()->GetWebState()->GetBrowserState();
ios::ChromeBrowserState* chrome_browser_state = ChromeBrowserState* chrome_browser_state =
ios::ChromeBrowserState::FromBrowserState(browser_state) ChromeBrowserState::FromBrowserState(browser_state)
->GetOriginalChromeBrowserState(); ->GetOriginalChromeBrowserState();
NSArray<TabModel*>* tab_models = NSArray<TabModel*>* tab_models =
TabModelList::GetTabModelsForChromeBrowserState(chrome_browser_state); TabModelList::GetTabModelsForChromeBrowserState(chrome_browser_state);
......
...@@ -51,7 +51,7 @@ web::WebUIIOSDataSource* CreateTranslateInternalsHTMLSource() { ...@@ -51,7 +51,7 @@ web::WebUIIOSDataSource* CreateTranslateInternalsHTMLSource() {
TranslateInternalsUI::TranslateInternalsUI(web::WebUIIOS* web_ui) TranslateInternalsUI::TranslateInternalsUI(web::WebUIIOS* web_ui)
: web::WebUIIOSController(web_ui) { : web::WebUIIOSController(web_ui) {
web_ui->AddMessageHandler(std::make_unique<IOSTranslateInternalsHandler>()); web_ui->AddMessageHandler(std::make_unique<IOSTranslateInternalsHandler>());
web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), web::WebUIIOSDataSource::Add(ChromeBrowserState::FromWebUIIOS(web_ui),
CreateTranslateInternalsHTMLSource()); CreateTranslateInternalsHTMLSource());
} }
......
...@@ -81,7 +81,7 @@ UkmInternalsUI::UkmInternalsUI(web::WebUIIOS* web_ui) ...@@ -81,7 +81,7 @@ UkmInternalsUI::UkmInternalsUI(web::WebUIIOS* web_ui)
web_ui->AddMessageHandler(std::make_unique<UkmMessageHandler>(ukm_service)); web_ui->AddMessageHandler(std::make_unique<UkmMessageHandler>(ukm_service));
// Set up the chrome://ukm/ source. // Set up the chrome://ukm/ source.
web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), web::WebUIIOSDataSource::Add(ChromeBrowserState::FromWebUIIOS(web_ui),
CreateUkmInternalsUIHTMLSource()); CreateUkmInternalsUIHTMLSource());
} }
......
...@@ -25,7 +25,7 @@ UserActionsUI::UserActionsUI(web::WebUIIOS* web_ui) ...@@ -25,7 +25,7 @@ UserActionsUI::UserActionsUI(web::WebUIIOS* web_ui)
html_source->SetDefaultResource(IDR_USER_ACTIONS_HTML); html_source->SetDefaultResource(IDR_USER_ACTIONS_HTML);
html_source->AddResourcePath("user_actions.css", IDR_USER_ACTIONS_CSS); html_source->AddResourcePath("user_actions.css", IDR_USER_ACTIONS_CSS);
html_source->AddResourcePath("user_actions.js", IDR_USER_ACTIONS_JS); html_source->AddResourcePath("user_actions.js", IDR_USER_ACTIONS_JS);
web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), web::WebUIIOSDataSource::Add(ChromeBrowserState::FromWebUIIOS(web_ui),
html_source); html_source);
} }
......
...@@ -114,7 +114,7 @@ web::WebUIIOSDataSource* CreateVersionUIDataSource() { ...@@ -114,7 +114,7 @@ web::WebUIIOSDataSource* CreateVersionUIDataSource() {
VersionUI::VersionUI(web::WebUIIOS* web_ui) : web::WebUIIOSController(web_ui) { VersionUI::VersionUI(web::WebUIIOS* web_ui) : web::WebUIIOSController(web_ui) {
web_ui->AddMessageHandler(std::make_unique<VersionHandler>()); web_ui->AddMessageHandler(std::make_unique<VersionHandler>());
web::WebUIIOSDataSource::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui), web::WebUIIOSDataSource::Add(ChromeBrowserState::FromWebUIIOS(web_ui),
CreateVersionUIDataSource()); CreateVersionUIDataSource());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment