Remove AppService enable function.

AppService has been enabled for a few releases and a few months, and it
will be enabled as default. So we don't need a function just
'return true' to reduce the function call for the chromebook start up
process.

BUG=1016159

Change-Id: I9aa30926267ae146802283fd9a2390a7724c407f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933669Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719436}

chrome/browser/apps/app_service/app_service_proxy_factory.cc

@@ -40,11 +40,6 @@ AppServiceProxyFactory* AppServiceProxyFactory::GetInstance() {
   return base::Singleton<AppServiceProxyFactory>::get();
 }
 
-// static
-bool AppServiceProxyFactory::IsEnabled() {
-  return true;
-}
-
 AppServiceProxyFactory::AppServiceProxyFactory()
     : BrowserContextKeyedServiceFactory(
           "AppServiceProxy",

chrome/browser/apps/app_service/app_service_proxy_factory.h

@@ -22,8 +22,6 @@ class AppServiceProxyFactory : public BrowserContextKeyedServiceFactory {
 
   static AppServiceProxyFactory* GetInstance();
 
-  static bool IsEnabled();
-
  private:
   friend struct base::DefaultSingletonTraits<AppServiceProxyFactory>;
 

chrome/browser/apps/app_service/arc_apps_factory.cc

@@ -27,11 +27,6 @@ ArcAppsFactory* ArcAppsFactory::GetInstance() {
   return base::Singleton<ArcAppsFactory>::get();
 }
 
-// static
-bool ArcAppsFactory::IsEnabled() {
-  return AppServiceProxyFactory::IsEnabled();
-}
-
 // static
 void ArcAppsFactory::ShutDownForTesting(content::BrowserContext* context) {
   auto* factory = GetInstance();

chrome/browser/apps/app_service/arc_apps_factory.h

@@ -21,8 +21,6 @@ class ArcAppsFactory : public BrowserContextKeyedServiceFactory {
 
   static ArcAppsFactory* GetInstance();
 
-  static bool IsEnabled();
-
   static void ShutDownForTesting(content::BrowserContext* context);
 
  private:

chrome/browser/chromeos/arc/session/arc_service_launcher.cc

@@ -233,9 +233,7 @@ void ArcServiceLauncher::OnPrimaryUserProfilePrepared(Profile* profile) {
   ArcWakeLockBridge::GetForBrowserContext(profile);
   ArcWallpaperService::GetForBrowserContext(profile);
   GpuArcVideoServiceHost::GetForBrowserContext(profile);
-  if (apps::ArcAppsFactory::IsEnabled()) {
-    apps::ArcAppsFactory::GetForProfile(profile);
-  }
+  apps::ArcAppsFactory::GetForProfile(profile);
   chromeos::ApkWebAppService::Get(profile);
 
   // ARC Container-only services.

chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

@@ -204,9 +204,7 @@ void ChromeBrowserMainExtraPartsProfiles::
 #endif
 
 #if !defined(OS_ANDROID)
-  if (apps::AppServiceProxyFactory::IsEnabled()) {
-    apps::AppServiceProxyFactory::GetInstance();
-  }
+  apps::AppServiceProxyFactory::GetInstance();
 #endif
   AboutSigninInternalsFactory::GetInstance();
   AccountConsistencyModeManagerFactory::GetInstance();

chrome/browser/ui/web_applications/web_app_ui_manager_impl.cc

@@ -101,11 +101,10 @@ void WebAppUiManagerImpl::UninstallAndReplace(
 #endif
     }
 
-    if (apps::AppServiceProxyFactory::IsEnabled()) {
-      apps::AppServiceProxy* proxy =
-          apps::AppServiceProxyFactory::GetForProfile(profile_);
-      proxy->Uninstall(from_app, nullptr /* parent_window */);
-    }
+    apps::AppServiceProxy* proxy =
+        apps::AppServiceProxyFactory::GetForProfile(profile_);
+    DCHECK(proxy);
+    proxy->Uninstall(from_app, nullptr /* parent_window */);
   }
 }