Commit 0b7180a3 authored by Connor Clark's avatar Connor Clark Committed by Commit Bot

[DevTools] Update and re-enable audits layout tests.

Bug: 772558
Change-Id: If545da902c199f4162698052cd57a26795337071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928088
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: default avatarPaul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717504}
parent 1fa56a74
......@@ -1836,9 +1836,7 @@ crbug.com/520188 [ Win ] http/tests/local/fileapi/file-last-modified-after-delet
crbug.com/520611 [ Debug ] fast/filesystem/workers/file-writer-events-shared-worker.html [ Failure Pass ]
crbug.com/520194 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html [ Failure Pass ]
# Temporarily disable to land Audits Panel changes in DevTools
crbug.com/772558 http/tests/devtools/audits/ [ Pass Failure ]
# crbug.com/771233 [ Win10 ] http/tests/devtools/audits/ [ Skip ]
crbug.com/771233 [ Win10 ] http/tests/devtools/audits/ [ Skip ]
crbug.com/410974 fast/scroll-behavior/scroll-customization/scrollstate-basic.html [ Pass Failure ]
crbug.com/410974 fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html [ Pass Failure ]
......
......@@ -7,12 +7,12 @@ Tests that mobile emulation works.
[x] Best practices
[x] Accessibility
[x] SEO
[x] Clear storage
Run audits: enabled visible
[ ] Publisher Ads
Generate report: enabled visible
=============== Lighthouse Results ===============
URL: http://127.0.0.1:8000/devtools/audits/resources/audits-emulate-pass.html
Version: 5.5.0
Version: 5.7.0
TestedAsMobileDevice: true
ViewportDimensions: {
"innerWidth": 412,
......
......@@ -7,12 +7,12 @@ Tests that audits panel passes flags.
[x] Best practices
[x] Accessibility
[x] SEO
[x] Clear storage
Run audits: enabled visible
[ ] Publisher Ads
Generate report: enabled visible
=============== Lighthouse Results ===============
emulatedFormFactor: desktop
disableStorageReset: false
throttlingMethod: provided
throttlingMethod: devtools
TestedAsMobileDevice: false
......@@ -10,7 +10,10 @@
const dialogElement = AuditsTestRunner.getContainerElement();
dialogElement.querySelector('input[name="audits.device_type"][value="desktop"]').click();
dialogElement.querySelector('input[name="audits.throttling"][value="off"]').click();
// Turn off simulated throttling.
dialogElement.querySelector('.audits-settings-pane > div').shadowRoot
.querySelectorAll('span')[1].shadowRoot
.querySelector('input').click();
AuditsTestRunner.dumpStartAuditState();
AuditsTestRunner.getRunButton().click();
......
......@@ -7,24 +7,43 @@ Tests that audits panel works when only the pwa category is selected.
[ ] Best practices
[ ] Accessibility
[ ] SEO
[x] Clear storage
Run audits: enabled visible
[x] Publisher Ads
Generate report: enabled visible
=============== Audits run ===============
ad-blocking-tasks
ad-render-blocking-resources
ad-request-critical-path
ad-request-from-page-start
ad-top-of-viewport
ads-in-viewport
apple-touch-icon
async-ad-tags
bid-request-from-page-start
blocking-load-events
bottleneck-requests
content-width
duplicate-tags
first-ad-render
gpt-bids-parallel
installable-manifest
is-on-https
load-fast-enough-for-pwa
loads-ad-tag-over-https
loads-gpt-from-sgdn
offline-start-url
pwa-cross-browser
pwa-each-page-has-url
pwa-page-transitions
redirects-http
script-injected-tags
serial-header-bidding
service-worker
splash-screen
tag-load-time
themed-omnibox
viewport
viewport-ad-density
without-javascript
works-offline
......@@ -10,9 +10,8 @@ Tests that audits panel prevents run of unauditable pages.
[ ] Best practices
[ ] Accessibility
[ ] SEO
[ ] Clear storage
Help text: At least one category must be selected.
Run audits: disabled visible
[x] Publisher Ads
Generate report: enabled visible
**Allows audit with a single category**
......@@ -23,8 +22,8 @@ Run audits: disabled visible
[ ] Best practices
[ ] Accessibility
[ ] SEO
[ ] Clear storage
Run audits: enabled visible
[x] Publisher Ads
Generate report: enabled visible
**Allows audit on undockable page**
......@@ -35,8 +34,8 @@ Run audits: enabled visible
[ ] Best practices
[ ] Accessibility
[ ] SEO
[ ] Clear storage
Run audits: enabled visible
[x] Publisher Ads
Generate report: enabled visible
**Prevents audit on internal page**
......@@ -48,7 +47,7 @@ URL: about:blank
[ ] Best practices
[ ] Accessibility
[ ] SEO
[ ] Clear storage
[x] Publisher Ads
Help text: Can only audit HTTP/HTTPS pages and Chrome extensions. Navigate to a different page to start an audit.
Run audits: disabled visible
Generate report: disabled visible
......@@ -7,8 +7,8 @@ Tests that audits panel works.
[x] Best practices
[x] Accessibility
[x] SEO
[x] Clear storage
Run audits: enabled visible
[ ] Publisher Ads
Generate report: enabled visible
=============== Lighthouse Status Updates ===============
Loading…
......@@ -282,7 +282,7 @@ Generating results...
=============== Lighthouse Results ===============
URL: http://127.0.0.1:8000/devtools/resources/inspected-page.html
Version: 5.5.0
Version: 5.7.0
TestedAsMobileDevice: true
ViewportDimensions: {
"innerWidth": 981,
......
......@@ -7,22 +7,37 @@ Tests that audits panel renders View Trace button.
[ ] Best practices
[ ] Accessibility
[ ] SEO
[x] Clear storage
Run audits: enabled visible
[x] Publisher Ads
Generate report: enabled visible
=============== Audits run ===============
ad-blocking-tasks
ad-render-blocking-resources
ad-request-critical-path
ad-request-from-page-start
ad-top-of-viewport
ads-in-viewport
async-ad-tags
bid-request-from-page-start
blocking-load-events
bootup-time
bottleneck-requests
critical-request-chains
diagnostics
dom-size
duplicate-tags
efficient-animated-content
estimated-input-latency
final-screenshot
first-ad-render
first-contentful-paint
first-cpu-idle
first-meaningful-paint
font-display
gpt-bids-parallel
interactive
loads-ad-tag-over-https
loads-gpt-from-sgdn
main-thread-tasks
mainthread-work-breakdown
max-potential-fid
......@@ -36,7 +51,10 @@ redirects
render-blocking-resources
resource-summary
screenshot-thumbnails
script-injected-tags
serial-header-bidding
speed-index
tag-load-time
third-party-summary
time-to-first-byte
total-blocking-time
......@@ -52,6 +70,7 @@ uses-rel-preload
uses-responsive-images
uses-text-compression
uses-webp-images
viewport-ad-density
Showing view: timeline
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment