Commit 0b75ca71 authored by Chase Phillips's avatar Chase Phillips Committed by Commit Bot

Revert "ui: Lower applist and shelf blur quality"

This reverts commit 3856a7a9.

Reason for revert:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/35823
failed in compile:
FAILED: obj/ash/app_list/app_list/app_list_view.o 
...
-c ../../ash/app_list/views/app_list_view.cc -o obj/ash/app_list/app_list/app_list_view.o
../../ash/app_list/views/app_list_view.cc:513:43: error: no member named 'SetBackdropFilterQuality' in 'ui::Layer'
    app_list_background_shield_->layer()->SetBackdropFilterQuality(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ^
1 error generated.

Original change's description:
> ui: Lower applist and shelf blur quality
> 
> crrev.com/c/1300235 introduced the option to lower the quality of backdrop
> filters.
> 
> This CL lowers the quality of the backdrop blur one the shelf and the
> applist shield.
> 
> In this way the texture allocations needed to apply the filter by cc will
> be significantly smaller/faster and applying the filter itself will also
> be faster on the GPU.
> 
> Bug: 897369
> Change-Id: I57be9434c02b77b38315e0f998d23eda5d277e43
> Reviewed-on: https://chromium-review.googlesource.com/c/1306234
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603660}

TBR=oshima@chromium.org,dcastagna@chromium.org

Change-Id: Ie3fb29b6d37cd8b409ab5ac910b39a1c52531c6e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 897369
Reviewed-on: https://chromium-review.googlesource.com/c/1307058Reviewed-by: default avatarChase Phillips <cmp@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603746}
parent a789de20
...@@ -96,9 +96,6 @@ constexpr int kAppListBackgroundRadius = 28; ...@@ -96,9 +96,6 @@ constexpr int kAppListBackgroundRadius = 28;
// home launcher gestures, if they can be processed. // home launcher gestures, if they can be processed.
constexpr int kAppListHomeLaucherGesturesThreshold = 32; constexpr int kAppListHomeLaucherGesturesThreshold = 32;
// Quality of the shield background blur.
constexpr float kAppListBlurQuality = 0.25f;
// Set animation durations to 0 for testing. // Set animation durations to 0 for testing.
static bool short_animations_for_testing; static bool short_animations_for_testing;
...@@ -510,8 +507,6 @@ void AppListView::InitContents(int initial_apps_page) { ...@@ -510,8 +507,6 @@ void AppListView::InitContents(int initial_apps_page) {
app_list_background_shield_mask_->layer()); app_list_background_shield_mask_->layer());
app_list_background_shield_->layer()->SetBackgroundBlur( app_list_background_shield_->layer()->SetBackgroundBlur(
AppListConfig::instance().blur_radius()); AppListConfig::instance().blur_radius());
app_list_background_shield_->layer()->SetBackdropFilterQuality(
kAppListBlurQuality);
} }
AddChildView(app_list_background_shield_); AddChildView(app_list_background_shield_);
app_list_main_view_ = new AppListMainView(delegate_, this); app_list_main_view_ = new AppListMainView(delegate_, this);
......
...@@ -45,7 +45,6 @@ namespace { ...@@ -45,7 +45,6 @@ namespace {
constexpr int kShelfRoundedCornerRadius = 28; constexpr int kShelfRoundedCornerRadius = 28;
constexpr int kShelfBlurRadius = 10; constexpr int kShelfBlurRadius = 10;
constexpr float kShelfBlurQuality = 0.25f;
// Return the first or last focusable child of |root|. // Return the first or last focusable child of |root|.
views::View* FindFirstOrLastFocusableChild(views::View* root, views::View* FindFirstOrLastFocusableChild(views::View* root,
...@@ -199,7 +198,6 @@ void ShelfWidget::DelegateView::UpdateBackgroundBlur() { ...@@ -199,7 +198,6 @@ void ShelfWidget::DelegateView::UpdateBackgroundBlur() {
opaque_background_.SetBackgroundBlur(should_blur_background ? kShelfBlurRadius opaque_background_.SetBackgroundBlur(should_blur_background ? kShelfBlurRadius
: 0); : 0);
opaque_background_.SetBackdropFilterQuality(kShelfBlurQuality);
background_is_currently_blurred_ = should_blur_background; background_is_currently_blurred_ = should_blur_background;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment