Skip to content

GitLab

T
tangled
Commit 0b7c4c88 authored by Ben Pastene's avatar Ben Pastene Committed by Commit Bot
Browse files
Options

Revert "infra: Remove all CQ experiments while the CQ is overloaded." 

This reverts commit 72e0b5bb.

Reason for revert: xenial builderless pool now has some idle bots
Traffics back down; should be fine to re-enable experiments.

Original change's description:
> infra: Remove all CQ experiments while the CQ is overloaded.
> 
> A small attempt at reducing overall traffic to various pools.
> 
> Bug: 1116532
> Change-Id: I9c36e08a9babfa4a69d62bb246950ae48890e94c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357412
> Reviewed-by: Erik Staab <estaab@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798233}

TBR=estaab@chromium.org,bpastene@chromium.org,gbeaty@chromium.org

Change-Id: I1862724f7be1991b7545bd9ccf16c92f18e28394
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1116532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357466Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798354}
parent 1e9194fc
Hide whitespace changes
Inline Side-by-side
Showing with 77 additions and 39 deletions
infra/config/generated/commit-queue.cfg
View file @ 0b7c4c88
...@@ -215,7 +215,10 @@ config_groups { ...@@ -215,7 +215,10 @@ config_groups {
} }
builders { builders {
name: "chromium/try/android-marshmallow-x86-rel" name: "chromium/try/android-marshmallow-x86-rel"
includable_only: true experiment_percentage: 5
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
} }
builders { builders {
name: "chromium/try/android-official" name: "chromium/try/android-official"
...@@ -543,7 +546,10 @@ config_groups { ...@@ -543,7 +546,10 @@ config_groups {
} }
builders { builders {
name: "chromium/try/fuchsia-compile-x64-dbg" name: "chromium/try/fuchsia-compile-x64-dbg"
includable_only: true experiment_percentage: 50
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
} }
builders { builders {
name: "chromium/try/fuchsia-fyi-arm64-dbg" name: "chromium/try/fuchsia-fyi-arm64-dbg"
...@@ -851,7 +857,10 @@ config_groups { ...@@ -851,7 +857,10 @@ config_groups {
} }
builders { builders {
name: "chromium/try/ios-simulator-code-coverage" name: "chromium/try/ios-simulator-code-coverage"
includable_only: true experiment_percentage: 3
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
} }
builders { builders {
name: "chromium/try/ios-simulator-cr-recipe" name: "chromium/try/ios-simulator-cr-recipe"
...@@ -1022,7 +1031,14 @@ config_groups { ...@@ -1022,7 +1031,14 @@ config_groups {
} }
builders { builders {
name: "chromium/try/linux-perfetto-rel" name: "chromium/try/linux-perfetto-rel"
includable_only: true experiment_percentage: 100
location_regexp: ".+/[+]/base/trace_event/.+"
location_regexp: ".+/[+]/base/tracing/.+"
location_regexp: ".+/[+]/components/tracing/.+"
location_regexp: ".+/[+]/content/browser/tracing/.+"
location_regexp: ".+/[+]/services/tracing/.+"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
} }
builders { builders {
name: "chromium/try/linux-rel" name: "chromium/try/linux-rel"
...@@ -1223,7 +1239,10 @@ config_groups { ...@@ -1223,7 +1239,10 @@ config_groups {
} }
builders { builders {
name: "chromium/try/mac-coverage-rel" name: "chromium/try/mac-coverage-rel"
includable_only: true experiment_percentage: 3
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
} }
builders { builders {
name: "chromium/try/mac-dawn-rel" name: "chromium/try/mac-dawn-rel"
...@@ -2273,7 +2292,10 @@ config_groups { ...@@ -2273,7 +2292,10 @@ config_groups {
} }
builders { builders {
name: "chromium/try-m85/fuchsia_arm64" name: "chromium/try-m85/fuchsia_arm64"
includable_only: true experiment_percentage: 50
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
} }
builders { builders {
name: "chromium/try-m85/fuchsia_x64" name: "chromium/try-m85/fuchsia_x64"
......
infra/config/generated/cq-builders.md
View file @ 0b7c4c88
...@@ -337,3 +337,31 @@ builder. ...@@ -337,3 +337,31 @@ builder.
* [`//tools/clang/scripts/update.py`](https://cs.chromium.org/search?q=package:%5Echromium$+file:tools/clang/scripts/update.py) * [`//tools/clang/scripts/update.py`](https://cs.chromium.org/search?q=package:%5Echromium$+file:tools/clang/scripts/update.py)
* [`//ui/gl/.+`](https://cs.chromium.org/chromium/src/ui/gl/) * [`//ui/gl/.+`](https://cs.chromium.org/chromium/src/ui/gl/)
## Experimental builders
These builders are run on some percentage of builds. Their results are ignored
by CQ. These are often used to test new configurations before they are added
as required builders.
* [android-marshmallow-x86-rel](https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-x86-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+android-marshmallow-x86-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+android-marshmallow-x86-rel))
* Experiment percentage: 5
* [fuchsia-compile-x64-dbg](https://ci.chromium.org/p/chromium/builders/try/fuchsia-compile-x64-dbg) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+fuchsia-compile-x64-dbg)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+fuchsia-compile-x64-dbg))
* Experiment percentage: 50
* [ios-simulator-code-coverage](https://ci.chromium.org/p/chromium/builders/try/ios-simulator-code-coverage) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+ios-simulator-code-coverage)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+ios-simulator-code-coverage))
* Experiment percentage: 3
* [linux-perfetto-rel](https://ci.chromium.org/p/chromium/builders/try/linux-perfetto-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+linux-perfetto-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+linux-perfetto-rel))
* Experiment percentage: 100
Path regular expressions:
* [`//base/trace_event/.+`](https://cs.chromium.org/chromium/src/base/trace_event/)
* [`//base/tracing/.+`](https://cs.chromium.org/chromium/src/base/tracing/)
* [`//components/tracing/.+`](https://cs.chromium.org/chromium/src/components/tracing/)
* [`//content/browser/tracing/.+`](https://cs.chromium.org/chromium/src/content/browser/tracing/)
* [`//services/tracing/.+`](https://cs.chromium.org/chromium/src/services/tracing/)
* [mac-coverage-rel](https://ci.chromium.org/p/chromium/builders/try/mac-coverage-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+mac-coverage-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+mac-coverage-rel))
* Experiment percentage: 3
infra/config/subprojects/chromium/master-only/try.star
View file @ 0b7c4c88
...@@ -318,11 +318,9 @@ try_.chromium_linux_builder( ...@@ -318,11 +318,9 @@ try_.chromium_linux_builder(
try_.chromium_linux_builder( try_.chromium_linux_builder(
name = "fuchsia-compile-x64-dbg", name = "fuchsia-compile-x64-dbg",
# TODO(crbug.com/1116532): Move back to experimental once CQ has settled tryjob = try_.job(
# down. experiment_percentage = 50,
#tryjob = try_.job( ),
# experiment_percentage = 50,
#),
) )
try_.chromium_linux_builder( try_.chromium_linux_builder(
...@@ -388,18 +386,16 @@ try_.chromium_linux_builder( ...@@ -388,18 +386,16 @@ try_.chromium_linux_builder(
try_.chromium_linux_builder( try_.chromium_linux_builder(
name = "linux-perfetto-rel", name = "linux-perfetto-rel",
# TODO(crbug.com/1116532): Move back to experimental once CQ has settled tryjob = try_.job(
# down. experiment_percentage = 100,
#tryjob = try_.job( location_regexp = [
# experiment_percentage = 100, ".+/[+]/base/trace_event/.+",
# location_regexp = [ ".+/[+]/base/tracing/.+",
# ".+/[+]/base/trace_event/.+", ".+/[+]/components/tracing/.+",
# ".+/[+]/base/tracing/.+", ".+/[+]/content/browser/tracing/.+",
# ".+/[+]/components/tracing/.+", ".+/[+]/services/tracing/.+",
# ".+/[+]/content/browser/tracing/.+", ],
# ".+/[+]/services/tracing/.+", ),
# ],
#),
) )
try_.chromium_linux_builder( try_.chromium_linux_builder(
...@@ -512,9 +508,7 @@ try_.chromium_mac_builder( ...@@ -512,9 +508,7 @@ try_.chromium_mac_builder(
name = "mac-coverage-rel", name = "mac-coverage-rel",
use_clang_coverage = True, use_clang_coverage = True,
goma_jobs = goma.jobs.J150, goma_jobs = goma.jobs.J150,
# TODO(crbug.com/1116532): Move back to experimental once CQ has settled tryjob = try_.job(experiment_percentage = 3),
# down.
#tryjob = try_.job(experiment_percentage = 3),
) )
try_.chromium_mac_builder( try_.chromium_mac_builder(
...@@ -596,9 +590,7 @@ try_.chromium_mac_ios_builder( ...@@ -596,9 +590,7 @@ try_.chromium_mac_ios_builder(
properties = { properties = {
"xcode_build_version": "11e146", "xcode_build_version": "11e146",
}, },
# TODO(crbug.com/1116532): Move back to experimental once CQ has settled tryjob = try_.job(experiment_percentage = 3),
# down.
#tryjob = try_.job(experiment_percentage = 3),
) )
try_.chromium_mac_ios_builder( try_.chromium_mac_ios_builder(
......
infra/config/subprojects/chromium/try.star
View file @ 0b7c4c88
...@@ -127,11 +127,9 @@ try_.chromium_android_builder( ...@@ -127,11 +127,9 @@ try_.chromium_android_builder(
try_.chromium_android_builder( try_.chromium_android_builder(
name = "android-marshmallow-x86-rel", name = "android-marshmallow-x86-rel",
goma_jobs = goma.jobs.J150, goma_jobs = goma.jobs.J150,
# TODO(crbug.com/1116532): Move back to experimental once CQ has settled tryjob = try_.job(
# down. experiment_percentage = 5,
#tryjob = try_.job( ),
# experiment_percentage = 5,
#),
) )
# TODO(crbug.com/1111436) Added it back once all Pixel 1s are flashed # TODO(crbug.com/1111436) Added it back once all Pixel 1s are flashed
......
infra/config/subprojects/chromium/versioned/m85/buckets/try.star
View file @ 0b7c4c88
...@@ -336,11 +336,9 @@ try_.chromium_linux_builder( ...@@ -336,11 +336,9 @@ try_.chromium_linux_builder(
# monitoring stability and capacity. crbug.com/1042511 # monitoring stability and capacity. crbug.com/1042511
try_.chromium_linux_builder( try_.chromium_linux_builder(
name = "fuchsia_arm64", name = "fuchsia_arm64",
# TODO(crbug.com/1116532): Move back to experimental once CQ has settled tryjob = try_.job(
# down. experiment_percentage = 50,
#tryjob = try_.job( ),
# experiment_percentage = 50,
#),
) )
try_.chromium_linux_builder( try_.chromium_linux_builder(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment