Commit 0ba4c00b authored by Justin Cohen's avatar Justin Cohen Committed by Commit Bot

[ios] Disable failing tests for Xcode 11 beta 6.

Increases a webState timeout, disables a request desktop and two
share button tests.

Bug: 995797, 996541, 990186, 996544
Change-Id: I07c8dd52d0bb13c6c805ef35b2c727ec3deb84bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762331
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689326}
parent de05d274
...@@ -103,6 +103,11 @@ id<GREYMatcher> ShareMenuCollectionView() { ...@@ -103,6 +103,11 @@ id<GREYMatcher> ShareMenuCollectionView() {
} }
- (void)testActivityServiceControllerIsDisabled { - (void)testActivityServiceControllerIsDisabled {
// TODO(crbug.com/996541) Starting in Xcode 11 beta 6, the share button does
// not appear (even with a delay) flakily.
if (@available(iOS 13, *))
EARL_GREY_TEST_DISABLED(@"Test disabled on iOS13.");
// Open an un-shareable page. // Open an un-shareable page.
GURL kURL("chrome://version"); GURL kURL("chrome://version");
[ChromeEarlGrey loadURL:kURL]; [ChromeEarlGrey loadURL:kURL];
......
...@@ -96,6 +96,10 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse( ...@@ -96,6 +96,10 @@ std::unique_ptr<net::test_server::HttpResponse> StandardResponse(
// Voice search is not enabled on the bots, so the voice search button is // Voice search is not enabled on the bots, so the voice search button is
// not tested here. // not tested here.
- (void)testTrailingButton { - (void)testTrailingButton {
// TODO(crbug.com/996541) Starting in Xcode 11 beta 6, the share button does
// not appear (even with a delay) flakily.
if (@available(iOS 13, *))
EARL_GREY_TEST_DISABLED(@"Test disabled on iOS13.");
[self openPage1]; [self openPage1];
if ([ChromeEarlGrey isCompactWidth]) { if ([ChromeEarlGrey isCompactWidth]) {
......
...@@ -141,6 +141,10 @@ class UserAgentResponseProvider : public web::DataResponseProvider { ...@@ -141,6 +141,10 @@ class UserAgentResponseProvider : public web::DataResponseProvider {
// Tests that requesting desktop site of a page works and going back re-opens // Tests that requesting desktop site of a page works and going back re-opens
// mobile version of the page. // mobile version of the page.
- (void)testRequestDesktopSiteGoBackToMobile { - (void)testRequestDesktopSiteGoBackToMobile {
// TODO(crbug.com/990186): Re-enable this test.
if ([ChromeEarlGrey isSlimNavigationManagerEnabled])
EARL_GREY_TEST_DISABLED(@"Test disabled on SlimNavigationManager.");
std::unique_ptr<web::DataResponseProvider> provider( std::unique_ptr<web::DataResponseProvider> provider(
new UserAgentResponseProvider()); new UserAgentResponseProvider());
web::test::SetUpHttpServer(std::move(provider)); web::test::SetUpHttpServer(std::move(provider));
......
...@@ -464,7 +464,10 @@ TEST_P(WebStateTest, CallStopDuringSessionRestore) { ...@@ -464,7 +464,10 @@ TEST_P(WebStateTest, CallStopDuringSessionRestore) {
EXPECT_TRUE(navigation_manager->CanGoForward()); EXPECT_TRUE(navigation_manager->CanGoForward());
// Now wait until the last committed item is fully loaded. // Now wait until the last committed item is fully loaded.
EXPECT_TRUE(WaitUntilConditionOrTimeout(kWaitForPageLoadTimeout, ^{ // TODO(crbug.com/996544) On Xcode 11 beta 6 this became very slow. This
// appears to only affect simulator, and will hopefully be fixed in a future
// Xcode release. Revert this to |kWaitForPageLoadTimeout| alone when fixed.
EXPECT_TRUE(WaitUntilConditionOrTimeout(kWaitForPageLoadTimeout * 5, ^{
return !navigation_manager->GetPendingItem() && !web_state_ptr->IsLoading(); return !navigation_manager->GetPendingItem() && !web_state_ptr->IsLoading();
})); }));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment