Commit 0bbce607 authored by Ramin Halavati's avatar Ramin Halavati Committed by Commit Bot

Remove metrics preferences from incognito whitelist.

The following preferences are removed from persistent preferences in
incognito mode:
 - metrics::prefs::kInstallDate/kUnisntall*
 - metrics::prefs::kMetrics*
 - metrics::prefs::kStability*
 - metrics::prefs::k*CellDataUse

After this change, if these preferences are written to an incognito
profile, they would not be persisted in their regular profile.
All of these preferences are already written to local state.

Bug: 861722
Change-Id: Iad0df3d31462a8373432d38a591a131ea8e27679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095718
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749050}
parent 87e6caf4
......@@ -91,60 +91,6 @@ const char* const kPersistentPrefNames[] = {
prefs::kPartnerBookmarkMappings,
#endif // defined(OS_ANDROID)
// Metrics preferences are out of profile scope and are merged between
// incognito and regular modes.
metrics::prefs::kInstallDate,
metrics::prefs::kMetricsClientID,
metrics::prefs::kMetricsDefaultOptIn,
metrics::prefs::kMetricsInitialLogs,
metrics::prefs::kMetricsLowEntropySource,
metrics::prefs::kMetricsMachineId,
metrics::prefs::kMetricsOngoingLogs,
metrics::prefs::kMetricsResetIds,
metrics::prefs::kMetricsReportingEnabled,
metrics::prefs::kMetricsReportingEnabledTimestamp,
metrics::prefs::kMetricsSessionID,
metrics::prefs::kMetricsLastSeenPrefix,
metrics::prefs::kStabilityBreakpadRegistrationFail,
metrics::prefs::kStabilityBreakpadRegistrationSuccess,
metrics::prefs::kStabilityBrowserLastLiveTimeStamp,
metrics::prefs::kStabilityChildProcessCrashCount,
metrics::prefs::kStabilityCrashCount,
metrics::prefs::kStabilityCrashCountDueToGmsCoreUpdate,
metrics::prefs::kStabilityCrashCountWithoutGmsCoreUpdateObsolete,
metrics::prefs::kStabilityDebuggerNotPresent,
metrics::prefs::kStabilityDebuggerPresent,
metrics::prefs::kStabilityDeferredCount,
metrics::prefs::kStabilityDiscardCount,
metrics::prefs::kStabilityExecutionPhase,
metrics::prefs::kStabilityExitedCleanly,
metrics::prefs::kStabilityExtensionRendererCrashCount,
metrics::prefs::kStabilityExtensionRendererFailedLaunchCount,
metrics::prefs::kStabilityExtensionRendererLaunchCount,
metrics::prefs::kStabilityGmsCoreVersion,
metrics::prefs::kStabilityGpuCrashCount,
metrics::prefs::kStabilityIncompleteSessionEndCount,
metrics::prefs::kStabilityLaunchCount,
metrics::prefs::kStabilityPageLoadCount,
metrics::prefs::kStabilityRendererCrashCount,
metrics::prefs::kStabilityRendererFailedLaunchCount,
metrics::prefs::kStabilityRendererHangCount,
metrics::prefs::kStabilityRendererLaunchCount,
metrics::prefs::kStabilitySavedSystemProfile,
metrics::prefs::kStabilitySavedSystemProfileHash,
metrics::prefs::kStabilitySessionEndCompleted,
metrics::prefs::kStabilityStatsBuildTime,
metrics::prefs::kStabilityStatsVersion,
metrics::prefs::kStabilitySystemCrashCount,
metrics::prefs::kStabilityVersionMismatchCount,
metrics::prefs::kUninstallLaunchCount,
metrics::prefs::kUninstallMetricsPageLoadCount,
metrics::prefs::kUninstallMetricsUptimeSec,
metrics::prefs::kUkmCellDataUse,
metrics::prefs::kUmaCellDataUse,
metrics::prefs::kUserCellDataUse,
#if defined(OS_ANDROID)
// Clipboard modification state is updated over all profiles.
prefs::kClipboardLastModifiedTime,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment