[js-code-coverage] Disable $i18n{} for Files app during browser tests
When collecting JS code coverage for Files app, $i18n labels are being replaced per normal, but that causes a mismatch in character offsets in the JS coverage data compared to the original JS source files. Disable $i18n{} JS string replacements for ChromeOS FilesApp extension when the --devtools-code-coverage flag is supplied. For now, the only builder running the Files app tests with the JS code --devtools-code-coverage flag is a CI builder: linux-chromeos-js-code-coverage which is in development. Followup CLs will start updating the files app tests to work with both this disabled $i18n{} mode, and the normal app $i18n{} replaced mode, using a files app browser test sendTestCommand helper called 'devtoolsCoverageActive' (added in this CL). :Gallery*:*FilesApp*:*SelectFileDialogExtension* Bug: 1152612 Test: browser_tests --gtest_filer=*AudioPlayer*:VideoPlayer*\ Change-Id: I62eb2c66ea0c2d7ef0158dedbc41928d6e3b75ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559234 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by:Ben Wells <benwells@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#830858}
Showing
Please register or sign in to comment