Prevent syncing of networks created by policy.

This was accidentally removed as part of an earlier refactor.  Made the
check explicit and added unittests.

Bug: 966270
Change-Id: I5b41b09623c9de41cbcd29e0b9802be93250a0fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222722Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773774}

chromeos/components/sync_wifi/local_network_collector_impl.cc

@@ -134,7 +134,8 @@ bool LocalNetworkCollectorImpl::IsEligible(
   const network_config::mojom::WiFiStatePropertiesPtr& wifi_properties =
       network->type_state->get_wifi();
   return IsEligibleForSync(network->guid, network->connectable,
-                           wifi_properties->security, /*log_result=*/true);
+                           wifi_properties->security, network->source,
+                           /*log_result=*/true);
 }
 
 void LocalNetworkCollectorImpl::StartGetNetworkDetails(

chromeos/components/sync_wifi/local_network_collector_impl_unittest.cc

@@ -43,6 +43,7 @@ const char kAnnieSsid[] = "Annie";
 const char kOzzySsid[] = "Ozzy";
 const char kHopperSsid[] = "Hopper";
 const char kByteSsid[] = "Byte";
+const char kWalterSsid[] = "Walter";
 
 }  // namespace
 
@@ -146,6 +147,11 @@ TEST_F(LocalNetworkCollectorImplTest,
   helper()->ConfigureWiFiNetwork(kByteSsid, /*is_secured=*/true,
                                  /*in_profile=*/false, /*has_connected=*/true,
                                  /*owned_by_user=*/true);
+  helper()->ConfigureWiFiNetwork(kWalterSsid, /*is_secured=*/true,
+                                 /*in_profile=*/false, /*has_connected=*/true,
+                                 /*owned_by_user=*/true,
+                                 /*configured_by_sync=*/false,
+                                 /*is_from_policy=*/true);
 
   std::vector<std::string> expected;
   expected.push_back(kByteSsid);
@@ -193,6 +199,14 @@ TEST_F(LocalNetworkCollectorImplTest, TestGetSyncableNetwork_NeverConnected) {
   TestGetSyncableNetwork(guid, /*expected_ssid=*/std::string());
 }
 
+TEST_F(LocalNetworkCollectorImplTest, TestGetSyncableNetwork_FromPolicy) {
+  std::string guid = helper()->ConfigureWiFiNetwork(
+      kFredSsid, /*is_secured=*/true,
+      /*in_profile=*/true, /*has_connected=*/true, /*owned_by_user=*/true,
+      /*configured_by_sync=*/false, /*is_from_policy=*/true);
+  TestGetSyncableNetwork(guid, /*expected_ssid=*/std::string());
+}
+
 }  // namespace sync_wifi
 
 }  // namespace chromeos

chromeos/components/sync_wifi/network_eligibility_checker.cc

@@ -17,6 +17,7 @@ namespace sync_wifi {
 bool IsEligibleForSync(const std::string& guid,
                        bool is_connectable,
                        const network_config::mojom::SecurityType& security_type,
+                       const network_config::mojom::OncSource& source,
                        bool log_result) {
   NetworkMetadataStore* network_metadata_store =
       NetworkHandler::IsInitialized()
@@ -25,6 +26,15 @@ bool IsEligibleForSync(const std::string& guid,
   if (!network_metadata_store)
     return false;
 
+  if (source == network_config::mojom::OncSource::kDevicePolicy ||
+      source == network_config::mojom::OncSource::kUserPolicy) {
+    if (log_result) {
+      NET_LOG(EVENT) << NetworkGuidId(guid)
+                     << " is not eligible, configured by policy.";
+    }
+    return false;
+  }
+
   if (!is_connectable) {
     if (log_result) {
       NET_LOG(EVENT) << NetworkGuidId(guid)

chromeos/components/sync_wifi/network_eligibility_checker.h

@@ -17,6 +17,7 @@ namespace sync_wifi {
 bool IsEligibleForSync(const std::string& guid,
                        bool is_connectable,
                        const network_config::mojom::SecurityType& security_type,
+                       const network_config::mojom::OncSource& source,
                        bool log_result);
 
 }  // namespace sync_wifi

chromeos/components/sync_wifi/network_test_helper.cc

@@ -94,21 +94,27 @@ std::string NetworkTestHelper::ConfigureWiFiNetwork(const std::string& ssid,
                                                     bool in_profile,
                                                     bool has_connected,
                                                     bool owned_by_user,
-                                                    bool configured_by_sync) {
+                                                    bool configured_by_sync,
+                                                    bool is_from_policy) {
   std::string security_entry =
       is_secured ? R"("SecurityClass": "psk", "Passphrase": "secretsauce", )"
                  : R"("SecurityClass": "none", )";
   std::string profile_entry = base::StringPrintf(
       R"("Profile": "%s", )",
       in_profile ? network_state_helper_->UserHash() : "/profile/default");
+  std::string ui_data = "";
+  if (is_from_policy) {
+    ui_data = base::StringPrintf(R"("UIData": "{\"onc_source\": \"%s\"}")",
+                                 in_profile ? "user_policy" : "device_policy");
+  }
   std::string guid = base::StringPrintf("%s_guid", ssid.c_str());
   std::string service_path =
       network_state_helper_->ConfigureService(base::StringPrintf(
           R"({"GUID": "%s", "Type": "wifi", "SSID": "%s",
             %s "State": "ready", "Strength": 100,
-            %s "AutoConnect": true, "Connectable": true})",
+            %s "AutoConnect": true, "Connectable": true, %s})",
           guid.c_str(), ssid.c_str(), security_entry.c_str(),
-          profile_entry.c_str()));
+          profile_entry.c_str(), ui_data.c_str()));
 
   base::RunLoop().RunUntilIdle();
 

chromeos/components/sync_wifi/network_test_helper.h

@@ -40,7 +40,8 @@ class NetworkTestHelper : public network_config::CrosNetworkConfigTestHelper {
                                    bool in_profile,
                                    bool has_connected,
                                    bool owned_by_user = true,
-                                   bool configured_by_sync = false);
+                                   bool configured_by_sync = false,
+                                   bool is_from_policy = false);
 
   NetworkStateTestHelper* network_state_test_helper();
 

chromeos/services/network_config/cros_network_config.cc

@@ -1423,7 +1423,7 @@ mojom::ManagedPropertiesPtr ManagedPropertiesToMojo(
       wifi->tethering_state =
           GetString(wifi_dict, ::onc::wifi::kTetheringState);
       wifi->is_syncable = sync_wifi::IsEligibleForSync(
-          result->guid, result->connectable, wifi->security,
+          result->guid, result->connectable, wifi->security, result->source,
           /*log_result=*/false);
       wifi->is_configured_by_active_user = GetIsConfiguredByUser(result->guid);