Commit 0c003ba4 authored by phoglund's avatar phoglund Committed by Commit bot

Removed hangup testing from AppRTC test.

I didn't realize the test actually hangs up the call as well. How
prudent of it! Now that the hangup code changed and isn't readily
available from the global namespace, I'll just remove it. Checking that
we can hang up isn't the most important thing anyway.

BUG=None
TBR=jiayl@chromium.org

Review URL: https://codereview.chromium.org/832593003

Cr-Commit-Position: refs/heads/master@{#311466}
parent daa138be
......@@ -155,11 +155,6 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
tab_contents);
}
bool WaitForCallToHangUp(content::WebContents* tab_contents) {
return test::PollingWaitUntil(kIsApprtcCallUpJavascript, "false",
tab_contents);
}
bool EvalInJavascriptFile(content::WebContents* tab_contents,
const base::FilePath& path) {
std::string javascript;
......@@ -190,11 +185,6 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
return true;
}
bool HangUpApprtcCall(content::WebContents* tab_contents) {
// This is the same as clicking the Hangup button in the AppRTC call.
return content::ExecuteScript(tab_contents, "hangup()");
}
base::FilePath GetSourceDir() {
base::FilePath source_dir;
PathService::Get(base::DIR_SOURCE_ROOT, &source_dir);
......@@ -260,11 +250,6 @@ IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest, MANUAL_WorksOnApprtc) {
ASSERT_TRUE(DetectRemoteVideoPlaying(left_tab));
ASSERT_TRUE(DetectRemoteVideoPlaying(right_tab));
ASSERT_TRUE(HangUpApprtcCall(left_tab));
ASSERT_TRUE(WaitForCallToHangUp(left_tab));
ASSERT_TRUE(WaitForCallToHangUp(right_tab));
chrome::CloseWebContents(browser(), left_tab, false);
chrome::CloseWebContents(browser(), right_tab, false);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment