Commit 0c0fcbe9 authored by Henrik Kjellander's avatar Henrik Kjellander Committed by Commit Bot

Disable InputHandlerManagerDestroyedAfterCompositorThread on Windows

The test RenderThreadImplBrowserTest.InputHandlerManagerDestroyedAfterCompositorThread
is flaky on Windows, with first obvservation being
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/24771

BUG=728034
TBR=skyostil@chromium.org

Change-Id: Icf3a073407eb8eaa13c111987544d887bcac68ca
Reviewed-on: https://chromium-review.googlesource.com/518822Reviewed-by: default avatarHenrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Cr-Commit-Position: refs/heads/master@{#475839}
parent 3a7275f8
...@@ -269,8 +269,16 @@ void CheckRenderThreadInputHandlerManager(RenderThreadImpl* thread) { ...@@ -269,8 +269,16 @@ void CheckRenderThreadInputHandlerManager(RenderThreadImpl* thread) {
// Check that InputHandlerManager outlives compositor thread because it uses // Check that InputHandlerManager outlives compositor thread because it uses
// raw pointers to post tasks. // raw pointers to post tasks.
// Disabled under LeakSanitizer due to memory leaks. http://crbug.com/348994 // Disabled under LeakSanitizer due to memory leaks. http://crbug.com/348994
// Disabled on Windows due to flakiness: http://crbug.com/728034.
#if defined(OS_WIN)
#define MAYBE_InputHandlerManagerDestroyedAfterCompositorThread \
DISABLED_InputHandlerManagerDestroyedAfterCompositorThread
#else
#define MAYBE_InputHandlerManagerDestroyedAfterCompositorThread \
InputHandlerManagerDestroyedAfterCompositorThread
#endif
TEST_F(RenderThreadImplBrowserTest, TEST_F(RenderThreadImplBrowserTest,
WILL_LEAK(InputHandlerManagerDestroyedAfterCompositorThread)) { WILL_LEAK(MAYBE_InputHandlerManagerDestroyedAfterCompositorThread)) {
ASSERT_TRUE(thread_->input_handler_manager()); ASSERT_TRUE(thread_->input_handler_manager());
thread_->compositor_task_runner()->PostTask( thread_->compositor_task_runner()->PostTask(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment