Commit 0c1605b3 authored by kouhei@chromium.org's avatar kouhei@chromium.org

Oilpan: |SVGViewSpec::m_contextElement| should be a member.

r175772 changed lifetime of SVGViewSpec to be always same as SVGSVGElement,
so this weak-ref can now be made a strong-ref.

BUG=357163

Review URL: https://codereview.chromium.org/331583002

git-svn-id: svn://svn.chromium.org/blink/trunk@176001 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 00eff3ca
...@@ -214,13 +214,7 @@ bool SVGViewSpec::parseViewSpecInternal(const CharType* ptr, const CharType* end ...@@ -214,13 +214,7 @@ bool SVGViewSpec::parseViewSpecInternal(const CharType* ptr, const CharType* end
void SVGViewSpec::trace(Visitor* visitor) void SVGViewSpec::trace(Visitor* visitor)
{ {
visitor->registerWeakMembers<SVGViewSpec, &SVGViewSpec::clearWeakMembers>(this); visitor->trace(m_contextElement);
}
void SVGViewSpec::clearWeakMembers(Visitor* visitor)
{
if (!visitor->isAlive(m_contextElement))
detachContextElement();
} }
} }
...@@ -58,7 +58,6 @@ public: ...@@ -58,7 +58,6 @@ public:
void setZoomAndPan(unsigned short value, ExceptionState&); void setZoomAndPan(unsigned short value, ExceptionState&);
void trace(Visitor*); void trace(Visitor*);
void clearWeakMembers(Visitor*);
SVGSVGElement* contextElement() { return m_contextElement.get(); } SVGSVGElement* contextElement() { return m_contextElement.get(); }
...@@ -68,7 +67,7 @@ private: ...@@ -68,7 +67,7 @@ private:
template<typename CharType> template<typename CharType>
bool parseViewSpecInternal(const CharType* ptr, const CharType* end); bool parseViewSpecInternal(const CharType* ptr, const CharType* end);
RawPtrWillBeWeakMember<SVGSVGElement> m_contextElement; RawPtrWillBeMember<SVGSVGElement> m_contextElement;
RefPtr<SVGAnimatedTransformList> m_transform; RefPtr<SVGAnimatedTransformList> m_transform;
String m_viewTargetString; String m_viewTargetString;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment