Commit 0c3db1ae authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Commit Bot

[Sync] Remove unused parameter model.

This CL removes an unused |model| parameter from

BookmarkChangeProcessor: :SetBookmarkFavicon()
Change-Id: I0aa20f60d03caf1fbb45b3b9e2bc263e2a8d2f5f
Reviewed-on: https://chromium-review.googlesource.com/1162339
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580833}
parent f6af1216
...@@ -776,7 +776,7 @@ void BookmarkChangeProcessor::UpdateBookmarkWithSyncData( ...@@ -776,7 +776,7 @@ void BookmarkChangeProcessor::UpdateBookmarkWithSyncData(
node, node,
base::Time::FromInternalValue(specifics.creation_time_us())); base::Time::FromInternalValue(specifics.creation_time_us()));
} }
SetBookmarkFavicon(&sync_node, node, model, sync_client); SetBookmarkFavicon(&sync_node, node, sync_client);
model->SetNodeMetaInfoMap(node, *GetBookmarkMetaInfo(&sync_node)); model->SetNodeMetaInfoMap(node, *GetBookmarkMetaInfo(&sync_node));
} }
...@@ -835,7 +835,7 @@ const BookmarkNode* BookmarkChangeProcessor::CreateBookmarkNode( ...@@ -835,7 +835,7 @@ const BookmarkNode* BookmarkChangeProcessor::CreateBookmarkNode(
parent, index, title, url, create_time, parent, index, title, url, create_time,
GetBookmarkMetaInfo(sync_node).get()); GetBookmarkMetaInfo(sync_node).get());
if (node) if (node)
SetBookmarkFavicon(sync_node, node, model, sync_client); SetBookmarkFavicon(sync_node, node, sync_client);
} }
return node; return node;
...@@ -846,7 +846,6 @@ const BookmarkNode* BookmarkChangeProcessor::CreateBookmarkNode( ...@@ -846,7 +846,6 @@ const BookmarkNode* BookmarkChangeProcessor::CreateBookmarkNode(
void BookmarkChangeProcessor::SetBookmarkFavicon( void BookmarkChangeProcessor::SetBookmarkFavicon(
const syncer::BaseNode* sync_node, const syncer::BaseNode* sync_node,
const BookmarkNode* bookmark_node, const BookmarkNode* bookmark_node,
BookmarkModel* bookmark_model,
syncer::SyncClient* sync_client) { syncer::SyncClient* sync_client) {
const sync_pb::BookmarkSpecifics& specifics = const sync_pb::BookmarkSpecifics& specifics =
sync_node->GetBookmarkSpecifics(); sync_node->GetBookmarkSpecifics();
......
...@@ -119,11 +119,8 @@ class BookmarkChangeProcessor : public bookmarks::BookmarkModelObserver, ...@@ -119,11 +119,8 @@ class BookmarkChangeProcessor : public bookmarks::BookmarkModelObserver,
int index); int index);
// Sets the favicon of the given bookmark node from the given sync node. // Sets the favicon of the given bookmark node from the given sync node.
// |profile| is the profile that contains the HistoryService and BookmarkModel
// for the bookmark in question.
static void SetBookmarkFavicon(const syncer::BaseNode* sync_node, static void SetBookmarkFavicon(const syncer::BaseNode* sync_node,
const bookmarks::BookmarkNode* bookmark_node, const bookmarks::BookmarkNode* bookmark_node,
bookmarks::BookmarkModel* model,
syncer::SyncClient* sync_client); syncer::SyncClient* sync_client);
// Applies the 1x favicon |bitmap_data| and |icon_url| to |bookmark_node|. // Applies the 1x favicon |bitmap_data| and |icon_url| to |bookmark_node|.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment