Commit 0c437d0a authored by Sebastien Lalancette's avatar Sebastien Lalancette Committed by Commit Bot

[iOS] Adding Delete action to Reading List Context Menu

Bug: 1093302
Change-Id: I443f9ed3817c2c7e7df5a93c0c1f8545fa593afd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343576Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796379}
parent 1e09fd7b
......@@ -421,6 +421,8 @@ animationControllerForDismissedController:(UIViewController*)dismissed {
- (UIContextMenuConfiguration*)contextMenuConfigurationForItem:
(id<ReadingListListItem>)item API_AVAILABLE(ios(13.0)) {
__weak id<ReadingListListItemAccessibilityDelegate> accessibilityDelegate =
self.tableViewController;
__weak __typeof(self) weakSelf = self;
UIContextMenuActionProvider actionProvider =
......@@ -468,6 +470,10 @@ animationControllerForDismissedController:(UIViewController*)dismissed {
[menuElements addObject:[actionFactory actionToCopyURL:item.entryURL]];
[menuElements addObject:[actionFactory actionToDeleteWithBlock:^{
[accessibilityDelegate deleteItem:item];
}]];
return [UIMenu menuWithTitle:@"" children:menuElements];
};
......
......@@ -19,6 +19,7 @@
- (void)openItemOffline:(id<ReadingListListItem>)item;
- (void)markItemRead:(id<ReadingListListItem>)item;
- (void)markItemUnread:(id<ReadingListListItem>)item;
- (void)deleteItem:(id<ReadingListListItem>)item;
@end
......
......@@ -441,6 +441,16 @@ ReadingListSelectionState GetSelectionStateForSelectedCounts(
}
}
- (void)deleteItem:(id<ReadingListListItem>)item {
TableViewItem<ReadingListListItem>* tableViewItem =
base::mac::ObjCCastStrict<TableViewItem<ReadingListListItem>>(item);
if ([self.tableViewModel hasItem:tableViewItem]) {
NSIndexPath* indexPath =
[self.tableViewModel indexPathForItem:tableViewItem];
[self deleteItemsAtIndexPaths:@[ indexPath ]];
}
}
#pragma mark - ReadingListToolbarButtonCommands
- (void)enterReadingListEditMode {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment