Commit 0c7bb2bf authored by Bailey Berro's avatar Bailey Berro Committed by Commit Bot

Clean up SmbShare build guards for Chrome OS

Adds is_chromeos checks to the build files for the add-smb-share-dialog

Bug: chromium:887135
Change-Id: I7ba729324c9e523f82924927f6eab86be8e4247f
Reviewed-on: https://chromium-review.googlesource.com/c/1323806Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606916}
parent 187d6834
...@@ -8,8 +8,10 @@ js_type_check("closure_compile") { ...@@ -8,8 +8,10 @@ js_type_check("closure_compile") {
deps = [ deps = [
":downloads_browser_proxy", ":downloads_browser_proxy",
":downloads_page", ":downloads_page",
":smb_shares_page",
] ]
if (is_chromeos) {
deps += [ ":smb_shares_page" ]
}
} }
js_library("downloads_browser_proxy") { js_library("downloads_browser_proxy") {
...@@ -19,12 +21,14 @@ js_library("downloads_browser_proxy") { ...@@ -19,12 +21,14 @@ js_library("downloads_browser_proxy") {
] ]
} }
js_library("smb_shares_page") { if (is_chromeos) {
deps = [ js_library("smb_shares_page") {
"..:route", deps = [
"//ui/webui/resources/cr_components/chromeos/smb_shares:smb_browser_proxy", "..:route",
"//ui/webui/resources/js:web_ui_listener_behavior", "//ui/webui/resources/cr_components/chromeos/smb_shares:smb_browser_proxy",
] "//ui/webui/resources/js:web_ui_listener_behavior",
]
}
} }
js_library("downloads_page") { js_library("downloads_page") {
......
...@@ -4,6 +4,8 @@ ...@@ -4,6 +4,8 @@
import("//third_party/closure_compiler/compile_js.gni") import("//third_party/closure_compiler/compile_js.gni")
assert(is_chromeos, "SMB Shares is Chrome OS only.")
js_type_check("closure_compile") { js_type_check("closure_compile") {
deps = [ deps = [
":add_smb_share_dialog", ":add_smb_share_dialog",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment