Commit 0c8f6e9b authored by Peter Boström's avatar Peter Boström Committed by Commit Bot

Flip views-dialog button ordering on ChromeOS

This aligns views' platform style on ChromeOS with WebUI and Material.

Bug: chromium:849549
Change-Id: If63603310e5ee7219cb76fa8d82c27ef9f853cb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036890
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738024}
parent d4d10513
......@@ -22,7 +22,7 @@
namespace views {
#if defined(OS_WIN) || defined(OS_CHROMEOS)
#if defined(OS_WIN)
const bool PlatformStyle::kIsOkButtonLeading = true;
#else
const bool PlatformStyle::kIsOkButtonLeading = false;
......
......@@ -190,11 +190,7 @@ TEST_F(DialogClientViewTest, RemoveAndUpdateButtons) {
// Test that views inside the dialog client view have the correct focus order.
TEST_F(DialogClientViewTest, SetupFocusChain) {
#if defined(OS_WIN) || defined(OS_CHROMEOS)
const bool kIsOkButtonOnLeftSide = true;
#else
const bool kIsOkButtonOnLeftSide = false;
#endif
const bool kIsOkButtonOnLeftSide = PlatformStyle::kIsOkButtonLeading;
GetContentsView()->SetFocusBehavior(View::FocusBehavior::ALWAYS);
// Initially the dialog client view only contains the content view.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment