Commit 0c908f68 authored by mlcui's avatar mlcui Committed by Commit Bot

Fix "More info" link in echo dialog pointing to deprecated Help app

Change-Id: Iaadb846eae348b95ce5f71be17f97761af220821
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404283
Commit-Queue: Michael Cui <mlcui@google.com>
Reviewed-by: default avatarRachel Carpenter <carpenterr@chromium.org>
Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816450}
parent c7ddc296
......@@ -25,6 +25,7 @@
#include "chrome/browser/ui/browser_navigator_params.h"
#include "chrome/common/extensions/api/echo_private.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "chromeos/system/statistics_provider.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/pref_service.h"
......@@ -36,15 +37,6 @@
namespace echo_api = extensions::api::echo_private;
namespace {
// URL of "More info" link shown in echo dialog in GetUserConsent function.
const char kMoreInfoLink[] =
"chrome-extension://honijodknafkokifofgiaalefdiedpko/main.html?"
"answer=2677280";
} // namespace
namespace chromeos {
namespace echo_offer {
......@@ -213,7 +205,7 @@ void EchoPrivateGetUserConsentFunction::OnCancel() {
void EchoPrivateGetUserConsentFunction::OnMoreInfoLinkClicked() {
ChromeExtensionFunctionDetails details(this);
NavigateParams params(details.GetProfile(), GURL(kMoreInfoLink),
NavigateParams params(details.GetProfile(), GURL(chrome::kEchoLearnMoreURL),
ui::PAGE_TRANSITION_LINK);
// Open the link in a new window. The echo dialog is modal, so the current
// window is useless until the dialog is closed.
......
......@@ -346,6 +346,9 @@ const char kCupsPrintPPDLearnMoreURL[] =
const char kEasyUnlockLearnMoreUrl[] =
"https://support.google.com/chromebook/?p=smart_lock";
const char kEchoLearnMoreURL[] =
"chrome://help-app/help/sub/3399709/id/2703646";
const char kArcTermsPathFormat[] = "arc_tos/%s/terms.html";
const char kArcPrivacyPolicyPathFormat[] = "arc_tos/%s/privacy_policy.pdf";
......
......@@ -304,6 +304,9 @@ extern const char kCupsPrintPPDLearnMoreURL[];
// The URL for the "Learn more" link the the Easy Unlock settings.
extern const char kEasyUnlockLearnMoreUrl[];
// The URL for the help center article about redeeming Chromebook offers.
extern const char kEchoLearnMoreURL[];
// The URL for EOL notification
extern const char kEolNotificationURL[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment